From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH 2/3] acpi: Drop superfluous GLIB_CHECK_VERSION()
Date: Wed, 27 May 2015 19:55:54 +0200 [thread overview]
Message-ID: <1432749355-4960-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1432749355-4960-1-git-send-email-armbru@redhat.com>
The version check is always true since we require GLib 2.22+ (commit
f40685c). It dates back to commit 8b9c3b8 "acpi-build: fix build on
glib < 2.22", amended in commit fd8f5e3 "acpi-build: fix build on glib
< 2.14". I guess we could revert both of them now, but I'm not sure
it's worth the churn, so just drop the superfluous check instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/acpi/aml-build.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 65c9d00..9efbb37 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -922,9 +922,7 @@ void *acpi_data_push(GArray *table_data, unsigned size)
unsigned acpi_data_len(GArray *table)
{
-#if GLIB_CHECK_VERSION(2, 22, 0)
assert(g_array_get_element_size(table) == 1);
-#endif
return table->len;
}
--
1.9.3
next prev parent reply other threads:[~2015-05-27 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 17:55 [Qemu-devel] [PATCH 0/3] acpi: Clean up some GLib compatibility cruft Markus Armbruster
2015-05-27 17:55 ` [Qemu-devel] [PATCH 1/3] Revert "aml-build: fix build for glib < 2.22" Markus Armbruster
2015-05-27 17:55 ` Markus Armbruster [this message]
2015-05-27 17:55 ` [Qemu-devel] [PATCH 3/3] acpi: Simplify printing to dynamic string Markus Armbruster
2015-05-28 18:51 ` [Qemu-devel] [PATCH 0/3] acpi: Clean up some GLib compatibility cruft John Snow
2015-05-29 8:57 ` Igor Mammedov
2015-06-08 11:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432749355-4960-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).