From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxfwP-0004OP-OJ for qemu-devel@nongnu.org; Wed, 27 May 2015 14:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxfwJ-0002bF-IH for qemu-devel@nongnu.org; Wed, 27 May 2015 14:20:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47613 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxfwJ-0002b3-Ci for qemu-devel@nongnu.org; Wed, 27 May 2015 14:20:27 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Wed, 27 May 2015 20:20:12 +0200 Message-Id: <1432750824-27702-2-git-send-email-afaerber@suse.de> In-Reply-To: <1432750824-27702-1-git-send-email-afaerber@suse.de> References: <1432750824-27702-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL v2 01/12] qom: strdup() target property name on object_property_add_alias() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost , =?UTF-8?q?Andreas=20F=C3=A4rber?= From: Eduardo Habkost With this, object_property_add_alias() callers can safely free the target property name, like what already happens with the 'name' argument to all object_property_add*() functions. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas F=C3=A4rber --- qom/object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index b8dff43..550dd48 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1689,7 +1689,7 @@ void object_property_add_uint64_ptr(Object *obj, co= nst char *name, =20 typedef struct { Object *target_obj; - const char *target_name; + char *target_name; } AliasProperty; =20 static void property_get_alias(Object *obj, struct Visitor *v, void *opa= que, @@ -1720,6 +1720,7 @@ static void property_release_alias(Object *obj, con= st char *name, void *opaque) { AliasProperty *prop =3D opaque; =20 + g_free(prop->target_name); g_free(prop); } =20 @@ -1747,7 +1748,7 @@ void object_property_add_alias(Object *obj, const c= har *name, =20 prop =3D g_malloc(sizeof(*prop)); prop->target_obj =3D target_obj; - prop->target_name =3D target_name; + prop->target_name =3D g_strdup(target_name); =20 op =3D object_property_add(obj, name, prop_type, property_get_alias, --=20 2.1.4