From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxkbu-0000Xo-2N for qemu-devel@nongnu.org; Wed, 27 May 2015 19:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxkbq-0007cA-Sh for qemu-devel@nongnu.org; Wed, 27 May 2015 19:19:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxkbq-0007c6-NG for qemu-devel@nongnu.org; Wed, 27 May 2015 19:19:38 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id F358FA10A0 for ; Wed, 27 May 2015 23:19:37 +0000 (UTC) From: Bandan Das Date: Wed, 27 May 2015 19:19:12 -0400 Message-Id: <1432768754-28523-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH v3 0/2] monitor: suggest running "help" for command errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com Hi Markus, It seems we can directly use cmdline to track current location when parsing. It's not being reused anywhere else and my unit tests didn't show any problems. Am I missing something ? Once everything looks ok, I can rebase this on top of your patches. Thanks for taking the time to review this! Bandan v3: Track the current location directly in the command line [1/2] Fix potential qdict leak [1/2] Document char **endp [1/2] Rebase on top of changes and add reviewed-by [2/2] v2: Split up the command name and arguments parsing into separate functions. [1/2] Skip checking for failures with commands that use the .cmd_new interface or the async interface since they are scheduled for removal [2/2] Bandan Das (2): monitor: cleanup parsing of cmd name and cmd arguments When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP. monitor.c | 92 ++++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 55 insertions(+), 37 deletions(-) -- 2.1.0