qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	gtk-vnc-list@gnome.org, 772422@bugs.debian.org,
	qemu-devel@nongnu.org,
	Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>
Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map
Date: Thu, 28 May 2015 08:24:04 +0200	[thread overview]
Message-ID: <1432794244.12688.10.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20150527114025.GC6364@redhat.com>

  Hi,

> For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which
> does not match your patch.  I'm not sure where I got that mapping
> from originally - probably from the Linux kernel's XT <-> evdev
> keymapping tables.

Did some more testing, 0x7e seems to be the correct one.  Everything is
consistent with that one:  vnc client, input_event_key_* trace event,
input-events reporting within the guest.  So no change needed in
gtk-vnc, I'll update the qemu patch.

cheers,
  Gerd

  parent reply	other threads:[~2015-05-28  6:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 13:58 [Qemu-devel] [PATCH 1/2] kbd: add brazil kbd keys to qemu Gerd Hoffmann
2015-05-26 13:58 ` [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map Gerd Hoffmann
2015-05-27  9:27   ` Joao Luis Meloni Assirati
2015-05-27 14:32     ` Gerd Hoffmann
2015-05-27 19:04       ` Joao Luis Meloni Assirati
2015-05-27 11:19   ` Markus Armbruster
2015-05-27 11:35     ` Daniel P. Berrange
2015-05-27 14:39     ` Gerd Hoffmann
2015-05-27 11:40   ` Daniel P. Berrange
2015-05-27 14:42     ` Gerd Hoffmann
2015-05-28  6:24     ` Gerd Hoffmann [this message]
2015-05-28  8:52       ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432794244.12688.10.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=772422@bugs.debian.org \
    --cc=berrange@redhat.com \
    --cc=gtk-vnc-list@gnome.org \
    --cc=jlma@nonada.if.usp.br \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).