From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe9-0002HG-Um for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwe4-0003cE-GA for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:49 -0400 From: Shannon Zhao Date: Thu, 28 May 2015 20:08:42 +0800 Message-ID: <1432814932-12608-20-git-send-email-zhaoshenglong@huawei.com> In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 19/29] hw/openrisc/pic_cpu.c: Fix memory leak spotted by valgrind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org From: Shannon Zhao valgrind complains about: ==2442== 256 bytes in 1 blocks are definitely lost in loss record 803 of 952 ==2442== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==2442== by 0x1E22A7: malloc_and_trace (vl.c:2556) ==2442== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3) ==2442== by 0x22FF53: qemu_extend_irqs (irq.c:55) ==2442== by 0x22FFDF: qemu_allocate_irqs (irq.c:64) ==2442== by 0x1BCBBE: cpu_openrisc_pic_init (pic_cpu.c:55) ==2442== by 0x1BD3BA: openrisc_sim_init (openrisc_sim.c:121) ==2442== by 0x1E6672: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/openrisc/pic_cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/openrisc/pic_cpu.c b/hw/openrisc/pic_cpu.c index 2af1d60..8347f5c 100644 --- a/hw/openrisc/pic_cpu.c +++ b/hw/openrisc/pic_cpu.c @@ -57,4 +57,5 @@ void cpu_openrisc_pic_init(OpenRISCCPU *cpu) for (i = 0; i < NR_IRQS; i++) { cpu->env.irq[i] = qi[i]; } + g_free(qi); } -- 2.0.4