From: Shannon Zhao <zhaoshenglong@huawei.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru,
shannon.zhao@linaro.org, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 02/29] hw/ide/cmd646.c: Fix memory leak spotted by valgrind
Date: Thu, 28 May 2015 20:08:25 +0800 [thread overview]
Message-ID: <1432814932-12608-3-git-send-email-zhaoshenglong@huawei.com> (raw)
In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com>
From: Shannon Zhao <shannon.zhao@linaro.org>
valgrind complains about:
==23215== 32 bytes in 2 blocks are definitely lost in loss record 1,356 of 2,329
==23215== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==23215== by 0x27482B: malloc_and_trace (vl.c:2556)
==23215== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
==23215== by 0x2EEFD3: qemu_extend_irqs (irq.c:55)
==23215== by 0x2EF05F: qemu_allocate_irqs (irq.c:64)
==23215== by 0x305498: pci_cmd646_ide_realize (cmd646.c:364)
==23215== by 0x33DB29: pci_qdev_realize (pci.c:1781)
==23215== by 0x2EBB14: device_set_realized (qdev.c:1058)
==23215== by 0x3C1A0E: property_set_bool (object.c:1514)
==23215== by 0x3C0308: object_property_set (object.c:837)
==23215== by 0x3C262A: object_property_set_qobject (qom-qobject.c:24)
==23215== by 0x3C0577: object_property_set_bool (object.c:905)
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
hw/ide/cmd646.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c
index 66fb9d9..c9703e2 100644
--- a/hw/ide/cmd646.c
+++ b/hw/ide/cmd646.c
@@ -370,6 +370,7 @@ static void pci_cmd646_ide_realize(PCIDevice *dev, Error **errp)
d->bmdma[i].bus = &d->bus[i];
ide_register_restart_cb(&d->bus[i]);
}
+ g_free(irq);
vmstate_register(DEVICE(dev), 0, &vmstate_ide_pci, d);
qemu_register_reset(cmd646_reset, d);
--
2.0.4
next prev parent reply other threads:[~2015-05-28 12:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 12:08 [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 01/29] hw/ide/ahci.c: Fix memory leak spotted by valgrind Shannon Zhao
2015-05-28 12:16 ` Peter Maydell
2015-05-28 12:24 ` Shannon Zhao
2015-05-28 12:39 ` Peter Maydell
2015-05-28 12:08 ` Shannon Zhao [this message]
2015-05-28 12:08 ` [Qemu-devel] [PATCH 03/29] hw/i386/pc: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 04/29] hw/i386/pc_q35.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 05/29] hw/isa/lpc_ich9.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 06/29] hw/isa/i82378.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 07/29] hw/timer/arm_timer.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 08/29] hw/intc/exynos4210_gic.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 09/29] hw/sparc/leon3.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 10/29] hw/sparc/sun4m.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 11/29] hw/ppc/mac_oldworld.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 12/29] hw/ppc/ppc440_bamboo.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 13/29] hw/ppc/prep.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 14/29] hw/mips/mips_int.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 15/29] hw/mips/mips_jazz.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 16/29] hw/lm32/lm32_boards.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 17/29] hw/lm32/milkymist.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 18/29] hw/m68k/mcf5206.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 19/29] hw/openrisc/pic_cpu.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 20/29] hw/unicore32/puv3.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 21/29] hw/sh4/r2d.c: " Shannon Zhao
2015-05-28 12:46 ` Peter Maydell
2015-05-29 2:11 ` Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 22/29] hw/alpha/typhoon.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 23/29] hw/arm/nseries.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 24/29] hw/arm/omap_sx1.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 25/29] hw/arm/palm.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 26/29] hw/arm/spitz.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 27/29] hw/arm/tosa.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 28/29] hw/display/tc6393xb.c: " Shannon Zhao
2015-05-28 12:08 ` [Qemu-devel] [PATCH 29/29] hw/s390x/sclpcpu.c: " Shannon Zhao
2015-05-28 13:11 ` Cornelia Huck
2015-05-30 7:27 ` Shannon Zhao
2015-05-28 13:21 ` Peter Maydell
2015-05-30 10:34 ` Paolo Bonzini
2015-05-30 11:07 ` Shannon Zhao
2015-05-28 12:34 ` [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs Michael Tokarev
2015-05-29 2:21 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432814932-12608-3-git-send-email-zhaoshenglong@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).