From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwoh-0005QA-Qn for qemu-devel@nongnu.org; Thu, 28 May 2015 08:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwoc-0007yn-SX for qemu-devel@nongnu.org; Thu, 28 May 2015 08:21:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwoc-0007yN-OU for qemu-devel@nongnu.org; Thu, 28 May 2015 08:21:38 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 76765332F2B for ; Thu, 28 May 2015 12:21:38 +0000 (UTC) From: Markus Armbruster Date: Thu, 28 May 2015 14:21:29 +0200 Message-Id: <1432815695-31687-4-git-send-email-armbru@redhat.com> In-Reply-To: <1432815695-31687-1-git-send-email-armbru@redhat.com> References: <1432815695-31687-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com Failure to create a -object is a fatal error. However, we delay the actual exit until all -object are processed. On the one hand, this permits detection of genuine additional errors. On the other hand, it can muddy the waters with uninteresting additional errors, e.g. when a later -object tries to reference a prior one that failed. We generally stop right on the first bad option, so do that for -object as well. Signed-off-by: Markus Armbruster --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index a31e7a5..1553c9e 100644 --- a/vl.c +++ b/vl.c @@ -4050,7 +4050,7 @@ int main(int argc, char **argv, char **envp) } if (qemu_opts_foreach(qemu_find_opts("object"), - object_create, NULL, 0) != 0) { + object_create, NULL, 1) != 0) { exit(1); } -- 1.9.3