From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxycl-0003Re-7P for qemu-devel@nongnu.org; Thu, 28 May 2015 10:17:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxycg-0008Ru-7k for qemu-devel@nongnu.org; Thu, 28 May 2015 10:17:31 -0400 From: Paolo Bonzini Date: Thu, 28 May 2015 16:17:09 +0200 Message-Id: <1432822629-25401-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , armbru@redhat.com, "open list:Block layer core" bdrv_close already does that, and in fact hmp_drive_del would need another drain after the flush (which bdrv_close does). So remove the duplication. Signed-off-by: Paolo Bonzini --- blockdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..d506a70 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2143,9 +2143,6 @@ int hmp_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data) return -1; } - /* quiesce block driver; prevent further io */ - bdrv_drain_all(); - bdrv_flush(bs); bdrv_close(bs); /* if we have a device attached to this BlockDriverState -- 2.4.1