From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44791)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yy03e-0006ZQ-JK
	for qemu-devel@nongnu.org; Thu, 28 May 2015 11:49:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yy03d-0001A0-OP
	for qemu-devel@nongnu.org; Thu, 28 May 2015 11:49:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yy03d-00019q-Iv
	for qemu-devel@nongnu.org; Thu, 28 May 2015 11:49:21 -0400
Message-ID: <1432828153.6250.20.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 28 May 2015 17:49:13 +0200
In-Reply-To: <55673259.7060007@redhat.com>
References: <20150528125925.GG6488@HEDWIG.INI.CMU.EDU>
	<1432821161.6250.11.camel@nilsson.home.kraxel.org>
	<55672949.5000502@redhat.com>
	<1432824960.6250.14.camel@nilsson.home.kraxel.org>
	<55673259.7060007@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mst@redhat.com, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com, "Gabriel L. Somlo" <gsomlo@gmail.com>, lersek@redhat.com

On Do, 2015-05-28 at 17:20 +0200, Paolo Bonzini wrote:
> 
> On 28/05/2015 16:56, Gerd Hoffmann wrote:
> > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> > > index d8a8edd..c761291 100644
> > > --- a/hw/block/fdc.c
> > > +++ b/hw/block/fdc.c
> > > @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error **errp)
> > >  }
> > >  
> > >  static const MemoryRegionPortio fdc_portio_list[] = {
> > > -    { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> > > +    { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
> > >      { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
> > >      PORTIO_END_OF_LIST(),
> > >  };
> >
> > The io ranges for FDC0 in hw/i386/acpi-dsdt-isa.dsl are not consistent
> > with that though.  If 0x3f0 is correct (which seems to be the case from
> > a brief look) this needs to be fixed up.
> 
> Agreed.  Who draws the short straw? :)

====  <- mine is 4 ch^Winches ;)

cheers,
  Gerd

PS: patch sent.