From: Shannon Zhao <zhaoshenglong@huawei.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru,
shannon.zhao@linaro.org, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 13/13] hw/display/tc6393xb.c: Fix misusing qemu_allocate_irqs for single irq
Date: Fri, 29 May 2015 13:27:11 +0800 [thread overview]
Message-ID: <1432877231-5136-14-git-send-email-zhaoshenglong@huawei.com> (raw)
In-Reply-To: <1432877231-5136-1-git-send-email-zhaoshenglong@huawei.com>
From: Shannon Zhao <shannon.zhao@linaro.org>
valgrind complains about:
==3169== 8 bytes in 1 blocks are definitely lost in loss record 424 of 2,779
==3169== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==3169== by 0x3547D3: malloc_and_trace (vl.c:2556)
==3169== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
==3169== by 0x3ED9CF: qemu_extend_irqs (irq.c:55)
==3169== by 0x3EDA5B: qemu_allocate_irqs (irq.c:64)
==3169== by 0x426F74: tc6393xb_init (tc6393xb.c:574)
==3169== by 0x28B7B4: tosa_init (tosa.c:235)
==3169== by 0x358B9E: main (vl.c:4249)
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
hw/display/tc6393xb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c
index 66b7ade..f5f3f3e 100644
--- a/hw/display/tc6393xb.c
+++ b/hw/display/tc6393xb.c
@@ -571,7 +571,7 @@ TC6393xbState *tc6393xb_init(MemoryRegion *sysmem, uint32_t base, qemu_irq irq)
s->irq = irq;
s->gpio_in = qemu_allocate_irqs(tc6393xb_gpio_set, s, TC6393XB_GPIOS);
- s->l3v = *qemu_allocate_irqs(tc6393xb_l3v, s, 1);
+ s->l3v = qemu_allocate_irq(tc6393xb_l3v, s, 0);
s->blanked = 1;
s->sub_irqs = qemu_allocate_irqs(tc6393xb_sub_irq, s, TC6393XB_NR_IRQS);
--
2.0.4
next prev parent reply other threads:[~2015-05-29 5:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 5:26 [Qemu-devel] [PATCH v2 00/13] use qemu_allocate_irq not _irqs for single irq Shannon Zhao
2015-05-29 5:26 ` [Qemu-devel] [PATCH v2 01/13] hw/i386/pc: Fix misusing qemu_allocate_irqs " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 02/13] hw/isa/lpc_ich9.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 03/13] hw/isa/i82378.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 04/13] hw/timer/arm_timer.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 05/13] hw/intc/exynos4210_gic.c: Fix memory leak by adjusting order Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 06/13] hw/sparc/sun4m.c: Fix misusing qemu_allocate_irqs for single irq Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 07/13] hw/ppc/prep.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 08/13] hw/lm32/lm32_boards.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 09/13] hw/lm32/milkymist.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 10/13] hw/unicore32/puv3.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 11/13] hw/alpha/typhoon.c: " Shannon Zhao
2015-05-29 5:27 ` [Qemu-devel] [PATCH v2 12/13] hw/arm/nseries.c: " Shannon Zhao
2015-05-29 5:27 ` Shannon Zhao [this message]
2015-05-30 14:12 ` [Qemu-devel] [PATCH v2 00/13] use qemu_allocate_irq not _irqs " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432877231-5136-14-git-send-email-zhaoshenglong@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).