qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, Jason Wang <jasowang@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	cornelia.huck@de.ibm.com, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH V8 5/9] virtio-ccw: validate the number of queues against bus limitation
Date: Fri, 29 May 2015 14:15:28 +0800	[thread overview]
Message-ID: <1432880132-28477-6-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1432880132-28477-1-git-send-email-jasowang@redhat.com>

Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/s390x/virtio-ccw.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index aaa9833..18fc697 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1416,7 +1416,16 @@ static int virtio_ccw_load_config(DeviceState *d, QEMUFile *f)
 static void virtio_ccw_device_plugged(DeviceState *d, Error **errp)
 {
     VirtioCcwDevice *dev = VIRTIO_CCW_DEVICE(d);
+    VirtIODevice *vdev = virtio_bus_get_device(&dev->bus);
     SubchDev *sch = dev->sch;
+    int n = virtio_get_num_queues(vdev);
+
+    if (virtio_get_num_queues(vdev) > VIRTIO_CCW_QUEUE_MAX) {
+        error_setg(errp, "The nubmer of virtqueues %d "
+                   "exceeds ccw limit %d", n,
+                   VIRTIO_CCW_QUEUE_MAX);
+        return;
+    }
 
     sch->id.cu_model = virtio_bus_get_vdev_id(&dev->bus);
 
-- 
2.1.4

  parent reply	other threads:[~2015-05-29  6:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  6:15 [Qemu-devel] [PATCH V8 0/9] Support more virtio queues Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 1/9] virtio-net: adding all queues in .realize() Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 2/9] virtio: device_plugged() can fail Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 3/9] virtio: introduce virtio_get_num_queues() Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 4/9] virtio-ccw: introduce ccw specific queue limit Jason Wang
2015-05-29  6:15 ` Jason Wang [this message]
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 6/9] virtio-s390: introduce virito s390 " Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 7/9] virtio-s390: introduce virtio_s390_device_plugged() Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 8/9] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX Jason Wang
2015-05-29  6:15 ` [Qemu-devel] [PATCH V8 9/9] virtio: increase the queue limit to 1024 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432880132-28477-6-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).