From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, Jason Wang <jasowang@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Alexander Graf <agraf@suse.de>,
mst@redhat.com
Subject: [Qemu-devel] [PATCH V8 7/9] virtio-s390: introduce virtio_s390_device_plugged()
Date: Fri, 29 May 2015 14:15:30 +0800 [thread overview]
Message-ID: <1432880132-28477-8-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1432880132-28477-1-git-send-email-jasowang@redhat.com>
This patch introduce a virtio-s390 specific device_plugged() function
and doing the number of virtqueue validation inside.
Cc: Alexander Graf <agraf@suse.de>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/s390x/s390-virtio-bus.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
index 3801c73..cbb3f92 100644
--- a/hw/s390x/s390-virtio-bus.c
+++ b/hw/s390x/s390-virtio-bus.c
@@ -536,6 +536,19 @@ static unsigned virtio_s390_get_features(DeviceState *d)
return dev->host_features;
}
+static void virtio_s390_device_plugged(DeviceState *d, Error **errp)
+{
+ VirtIOS390Device *dev = to_virtio_s390_device(d);
+ VirtIODevice *vdev = virtio_bus_get_device(&dev->bus);
+ int n = virtio_get_num_queues(vdev);
+
+ if (n > VIRTIO_S390_QUEUE_MAX) {
+ error_setg(errp, "The nubmer of virtqueues %d "
+ "exceeds s390 limit %d", n,
+ VIRTIO_S390_QUEUE_MAX);
+ }
+}
+
/**************** S390 Virtio Bus Device Descriptions *******************/
static void s390_virtio_net_class_init(ObjectClass *klass, void *data)
@@ -736,6 +749,7 @@ static void virtio_s390_bus_class_init(ObjectClass *klass, void *data)
bus_class->max_dev = 1;
k->notify = virtio_s390_notify;
k->get_features = virtio_s390_get_features;
+ k->device_plugged = virtio_s390_device_plugged;
}
static const TypeInfo virtio_s390_bus_info = {
--
2.1.4
next prev parent reply other threads:[~2015-05-29 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 6:15 [Qemu-devel] [PATCH V8 0/9] Support more virtio queues Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 1/9] virtio-net: adding all queues in .realize() Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 2/9] virtio: device_plugged() can fail Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 3/9] virtio: introduce virtio_get_num_queues() Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 4/9] virtio-ccw: introduce ccw specific queue limit Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 5/9] virtio-ccw: validate the number of queues against bus limitation Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 6/9] virtio-s390: introduce virito s390 queue limit Jason Wang
2015-05-29 6:15 ` Jason Wang [this message]
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 8/9] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX Jason Wang
2015-05-29 6:15 ` [Qemu-devel] [PATCH V8 9/9] virtio: increase the queue limit to 1024 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432880132-28477-8-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).