Re: [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and acpi dsdt

[Gerd Hoffmann <kraxel@redhat.com>]

On Do, 2015-05-28 at 18:36 +0200, Kevin Wolf wrote:
> Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  hw/block/fdc.c            | 2 +-
> >  hw/i386/acpi-dsdt-isa.dsl | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> The commit message could be a bit longer, I don't think this change is
> obvious.
> 
> My FDC spec says that this version of the controller doesn't have the
> SRA register any more, and the emulation was added in the context of a
> Sun4m patch (commit 8c6a4d774). Therefore my default assumption would be
> that it's intentionally not accessible and not needed on isa-fdc.
> 
> I'm happy to get that assumption corrected, but it needs a non-empty
> commit message for that.

/me throws the towel.

I know next to nothing about floppy.  It's just that all parties ...

  (1) hw/block/fdc.c
  (2) hw/i386/acpi-dsdt-isa.dsl
  (3) hw/isa/lpc_ich9.c

... should agree on what the floppy io ranges are.  Right now they
don't, for whatever reasons.  And I simply don't know what are the
correct ranges.  So I leave fixing this up to whomever knows better this
than me.

cheers,
  Gerd