From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YyDdS-0003nY-Un
	for qemu-devel@nongnu.org; Fri, 29 May 2015 02:19:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YyDdR-0005m8-S6
	for qemu-devel@nongnu.org; Fri, 29 May 2015 02:19:14 -0400
Message-ID: <1432880345.19543.4.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 29 May 2015 08:19:05 +0200
In-Reply-To: <20150528163640.GE3385@noname.redhat.com>
References: <1432827461-1117-1-git-send-email-kraxel@redhat.com>
	<20150528163640.GE3385@noname.redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] floppy: fix I/O ranges in both portio and
	acpi dsdt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, "open
	list:Floppy" <qemu-block@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Richard Henderson <rth@twiddle.net>

On Do, 2015-05-28 at 18:36 +0200, Kevin Wolf wrote:
> Am 28.05.2015 um 17:37 hat Gerd Hoffmann geschrieben:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  hw/block/fdc.c            | 2 +-
> >  hw/i386/acpi-dsdt-isa.dsl | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> The commit message could be a bit longer, I don't think this change is
> obvious.
> 
> My FDC spec says that this version of the controller doesn't have the
> SRA register any more, and the emulation was added in the context of a
> Sun4m patch (commit 8c6a4d774). Therefore my default assumption would be
> that it's intentionally not accessible and not needed on isa-fdc.
> 
> I'm happy to get that assumption corrected, but it needs a non-empty
> commit message for that.

/me throws the towel.

I know next to nothing about floppy.  It's just that all parties ...

  (1) hw/block/fdc.c
  (2) hw/i386/acpi-dsdt-isa.dsl
  (3) hw/isa/lpc_ich9.c

... should agree on what the floppy io ranges are.  Right now they
don't, for whatever reasons.  And I simply don't know what are the
correct ranges.  So I leave fixing this up to whomever knows better this
than me.

cheers,
  Gerd