From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyHv7-00057T-Df for qemu-devel@nongnu.org; Fri, 29 May 2015 06:53:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyHv5-0006vT-TR for qemu-devel@nongnu.org; Fri, 29 May 2015 06:53:44 -0400 From: Fam Zheng Date: Fri, 29 May 2015 18:53:16 +0800 Message-Id: <1432896805-23867-4-git-send-email-famz@redhat.com> In-Reply-To: <1432896805-23867-1-git-send-email-famz@redhat.com> References: <1432896805-23867-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [RFC PATCH 03/12] blockdev: Lock BDS during internal snapshot transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , fam@euphon.net, qemu-block@nongnu.org, Jeff Cody , Stefan Hajnoczi , Paolo Bonzini Signed-off-by: Fam Zheng --- blockdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..46f8d60 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1262,6 +1262,7 @@ typedef struct InternalSnapshotState { BlockDriverState *bs; AioContext *aio_context; QEMUSnapshotInfo sn; + bool needs_unlock; } InternalSnapshotState; static void internal_snapshot_prepare(BlkTransactionState *common, @@ -1356,6 +1357,8 @@ static void internal_snapshot_prepare(BlkTransactionState *common, } /* 4. succeed, mark a snapshot is created */ + bdrv_lock(bs); + state->needs_unlock = true; state->bs = bs; } @@ -1387,6 +1390,9 @@ static void internal_snapshot_clean(BlkTransactionState *common) InternalSnapshotState *state = DO_UPCAST(InternalSnapshotState, common, common); + if (state->needs_unlock) { + bdrv_unlock(state->bs); + } if (state->aio_context) { aio_context_release(state->aio_context); } -- 2.4.2