From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyHvL-0005Ky-9J for qemu-devel@nongnu.org; Fri, 29 May 2015 06:54:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyHvI-0006xo-2P for qemu-devel@nongnu.org; Fri, 29 May 2015 06:53:59 -0400 From: Fam Zheng Date: Fri, 29 May 2015 18:53:19 +0800 Message-Id: <1432896805-23867-7-git-send-email-famz@redhat.com> In-Reply-To: <1432896805-23867-1-git-send-email-famz@redhat.com> References: <1432896805-23867-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [RFC PATCH 06/12] blockdev: Lock BDS during blockdev-backup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , fam@euphon.net, qemu-block@nongnu.org, Jeff Cody , Stefan Hajnoczi , Paolo Bonzini The change is similar to drive-backup in last patch. Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 517def4..80cf7d5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1669,6 +1669,8 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) return; } aio_context_acquire(state->aio_context); + state->bs = bs; + bdrv_lock(bs); qmp_blockdev_backup(backup->device, backup->target, backup->sync, @@ -1681,7 +1683,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) return; } - state->bs = bs; state->job = state->bs->job; } @@ -1701,6 +1702,7 @@ static void blockdev_backup_clean(BlkTransactionState *common) BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common); if (state->aio_context) { + bdrv_unlock(state->bs); aio_context_release(state->aio_context); } } -- 2.4.2