From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyJcd-0005Zm-K4 for qemu-devel@nongnu.org; Fri, 29 May 2015 08:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyJcc-0002mu-U1 for qemu-devel@nongnu.org; Fri, 29 May 2015 08:42:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyJcc-0002mp-PP for qemu-devel@nongnu.org; Fri, 29 May 2015 08:42:46 -0400 Message-ID: <1432903362.19543.31.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 29 May 2015 14:42:42 +0200 In-Reply-To: <1431953244-29304-1-git-send-email-somlo@cmu.edu> References: <1431953244-29304-1-git-send-email-somlo@cmu.edu> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] bios-tables-test: handle false-positive smbios signature matches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: mst@redhat.com, qemu-devel@nongnu.org, brogers@suse.com, gsomlo@gmail.com, kevin@koconnor.net On Mo, 2015-05-18 at 08:47 -0400, Gabriel L. Somlo wrote: > It has been reported that sometimes the .rodata section of SeaBIOS, > containing the constant string against which the SMBIOS signature > ends up being compared, also falls within the guest f-segment. In > that case, the test obviously fails, unless we continue searching > for the *real* SMBIOS entry point. > > Rather than stopping at the first match for the SMBIOS signature > ("_SM_") in the f-segment (0xF0000-0xFFFFF), continue scanning > until either a valid entry point table is found, or the f-segment > has been exhausted. added to fw_cfg queue too. cheers, Gerd