From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org,
christoffer.dall@linaro.org, zhichao.huang@linaro.org
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: [Qemu-devel] [PATCH v5 4/6] target-arm: kvm - support for single step
Date: Fri, 29 May 2015 16:19:22 +0100 [thread overview]
Message-ID: <1432912764-7073-5-git-send-email-alex.bennee@linaro.org> (raw)
In-Reply-To: <1432912764-7073-1-git-send-email-alex.bennee@linaro.org>
This adds support for single-step. There isn't much to do on the QEMU
side as after we set-up the request for single step via the debug ioctl
it is all handled within the kernel.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v2
- convert to using HSR_EC
v3
- use internals.h definitions
---
target-arm/kvm.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/target-arm/kvm.c b/target-arm/kvm.c
index c3bad6f..de2865a 100644
--- a/target-arm/kvm.c
+++ b/target-arm/kvm.c
@@ -528,6 +528,13 @@ static int kvm_handle_debug(CPUState *cs, struct kvm_run *run)
kvm_cpu_synchronize_state(cs);
switch (hsr_ec) {
+ case EC_SOFTWARESTEP:
+ if (cs->singlestep_enabled) {
+ return true;
+ } else {
+ error_report("Came out of SINGLE STEP when not enabled");
+ }
+ break;
case EC_AA64_BKPT:
if (kvm_find_sw_breakpoint(cs, env->pc)) {
return true;
@@ -588,6 +595,9 @@ int kvm_arch_on_sigbus(int code, void *addr)
void kvm_arch_update_guest_debug(CPUState *cs, struct kvm_guest_debug *dbg)
{
+ if (cs->singlestep_enabled) {
+ dbg->control |= KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTEP;
+ }
if (kvm_sw_breakpoints_active(cs)) {
dbg->control |= KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_USE_SW_BP;
}
--
2.4.1
next prev parent reply other threads:[~2015-05-29 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 15:19 [Qemu-devel] [PATCH v5 0/6] QEMU support for KVM Guest Debug on arm64 Alex Bennée
2015-05-29 15:19 ` [Qemu-devel] [PATCH v5 1/6] linux-headers: sync from my kernel tree (DEV) Alex Bennée
2015-05-29 15:19 ` [Qemu-devel] [PATCH v5 2/6] target-arm: kvm64: introduce kvm_arm_init_debug() Alex Bennée
2015-06-04 10:56 ` Peter Maydell
2015-05-29 15:19 ` [Qemu-devel] [PATCH v5 3/6] target-arm: kvm - implement software breakpoints Alex Bennée
2015-06-04 10:56 ` Peter Maydell
2015-05-29 15:19 ` Alex Bennée [this message]
2015-06-04 10:59 ` [Qemu-devel] [PATCH v5 4/6] target-arm: kvm - support for single step Peter Maydell
2015-05-29 15:19 ` [Qemu-devel] [PATCH v5 5/6] target-arm: kvm - add support for HW assisted debug Alex Bennée
2015-06-04 11:10 ` Peter Maydell
2015-05-29 15:19 ` [Qemu-devel] [PATCH v5 6/6] target-arm: kvm - re-inject guest debug exceptions Alex Bennée
2015-06-04 11:29 ` Peter Maydell
2015-06-04 11:35 ` [Qemu-devel] [PATCH v5 0/6] QEMU support for KVM Guest Debug on arm64 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432912764-7073-5-git-send-email-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhichao.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).