qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Jason Wang <jasowang@redhat.com>, Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 34/57] virtio-ccw: introduce ccw specific queue limit
Date: Sun, 31 May 2015 20:36:28 +0200	[thread overview]
Message-ID: <1433097192-8988-35-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1433097192-8988-1-git-send-email-mst@redhat.com>

From: Jason Wang <jasowang@redhat.com>

Cc: Alexander Graf <agraf@suse.de>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/s390x/s390_flic.h |  5 ++++-
 hw/s390x/s390-virtio-ccw.c   |  2 +-
 hw/s390x/virtio-ccw.c        | 12 ++++++------
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h
index 489d73b..200e7e9 100644
--- a/include/hw/s390x/s390_flic.h
+++ b/include/hw/s390x/s390_flic.h
@@ -17,10 +17,13 @@
 #include "hw/s390x/adapter.h"
 #include "hw/virtio/virtio.h"
 
+#define ADAPTER_ROUTES_MAX_GSI 64
+#define VIRTIO_CCW_QUEUE_MAX ADAPTER_ROUTES_MAX_GSI
+
 typedef struct AdapterRoutes {
     AdapterInfo adapter;
     int num_routes;
-    int gsi[VIRTIO_PCI_QUEUE_MAX];
+    int gsi[ADAPTER_ROUTES_MAX_GSI];
 } AdapterRoutes;
 
 #define TYPE_S390_FLIC_COMMON "s390-flic"
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index afb539a..8a565f6 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -67,7 +67,7 @@ static int virtio_ccw_hcall_notify(const uint64_t *args)
     if (!sch || !css_subch_visible(sch)) {
         return -EINVAL;
     }
-    if (queue >= VIRTIO_PCI_QUEUE_MAX) {
+    if (queue >= VIRTIO_CCW_QUEUE_MAX) {
         return -EINVAL;
     }
     virtio_queue_notify(virtio_ccw_get_vdev(sch), queue);
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 965b03a..60d60d6 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -170,7 +170,7 @@ static void virtio_ccw_start_ioeventfd(VirtioCcwDevice *dev)
         return;
     }
     vdev = virtio_bus_get_device(&dev->bus);
-    for (n = 0; n < VIRTIO_PCI_QUEUE_MAX; n++) {
+    for (n = 0; n < VIRTIO_CCW_QUEUE_MAX; n++) {
         if (!virtio_queue_get_num(vdev, n)) {
             continue;
         }
@@ -205,7 +205,7 @@ static void virtio_ccw_stop_ioeventfd(VirtioCcwDevice *dev)
         return;
     }
     vdev = virtio_bus_get_device(&dev->bus);
-    for (n = 0; n < VIRTIO_PCI_QUEUE_MAX; n++) {
+    for (n = 0; n < VIRTIO_CCW_QUEUE_MAX; n++) {
         if (!virtio_queue_get_num(vdev, n)) {
             continue;
         }
@@ -266,7 +266,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align,
 {
     VirtIODevice *vdev = virtio_ccw_get_vdev(sch);
 
-    if (index >= VIRTIO_PCI_QUEUE_MAX) {
+    if (index >= VIRTIO_CCW_QUEUE_MAX) {
         return -EINVAL;
     }
 
@@ -291,7 +291,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, uint64_t addr, uint32_t align,
         virtio_queue_set_vector(vdev, index, index);
     }
     /* tell notify handler in case of config change */
-    vdev->config_vector = VIRTIO_PCI_QUEUE_MAX;
+    vdev->config_vector = VIRTIO_CCW_QUEUE_MAX;
     return 0;
 }
 
@@ -573,7 +573,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
                                                     ccw.cda,
                                                     MEMTXATTRS_UNSPECIFIED,
                                                     NULL);
-            if (vq_config.index >= VIRTIO_PCI_QUEUE_MAX) {
+            if (vq_config.index >= VIRTIO_CCW_QUEUE_MAX) {
                 ret = -EINVAL;
                 break;
             }
@@ -1025,7 +1025,7 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t vector)
         return;
     }
 
-    if (vector < VIRTIO_PCI_QUEUE_MAX) {
+    if (vector < VIRTIO_CCW_QUEUE_MAX) {
         if (!dev->indicators) {
             return;
         }
-- 
MST

  parent reply	other threads:[~2015-05-31 18:36 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-31 18:34 [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 01/57] hw/virtio/virtio-balloon: move adding property to virtio_balloon_instance_init Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 02/57] hw/virtio/virtio-pci: use alias property for virtio-balloon-pci Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 03/57] hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 04/57] pc: Replace tab with spaces Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 05/57] hw: Move commas inside HW_COMPAT_2_1 macro Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 06/57] pc: Move commas inside PC_COMPAT_* macros Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 07/57] spapr: Move commas inside SPAPR_COMPAT_* macros Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 08/57] hw: Define empty HW_COMPAT_2_[23] macros Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 09/57] pc: Define PC_COMPAT_2_[123] macros Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 10/57] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros Michael S. Tsirkin
2015-05-31 18:34 ` [Qemu-devel] [PULL 11/57] spapr: define SPAPR_COMPAT_2_3 Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 12/57] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14 Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 13/57] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11 Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 14/57] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13 Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 15/57] piix: Move pc-0.1[23] rombar compat props " Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 16/57] piix: Define PC_COMPAT_0_10 Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 17/57] pc: Define MACHINE_OPTIONS macros consistently for all machines Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 18/57] pc: Define machines using a DEFINE_PC_MACHINE macro Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 19/57] pc: Convert *_MACHINE_OPTIONS macros into functions Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 20/57] pc: Move compat_props setting inside *_machine_options() functions Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 21/57] pc: Don't use QEMUMachine anymore Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 22/57] pc: Remove qemu_register_pc_machine() function Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 23/57] machine: Remove unused fields from QEMUMachine Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 24/57] piix: Add kvmclock_enabled, pci_enabled globals Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 25/57] piix: Eliminate pc_init_pci() Michael S. Tsirkin
2015-05-31 18:35 ` [Qemu-devel] [PULL 26/57] pc: Generate init functions with a macro Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 27/57] pc: acpi: fix pvpanic for buggy guests Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 28/57] virtio: move host_features Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 29/57] virtio-ccw: Don't advertise VIRTIO_F_BAD_FEATURE Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 30/57] virtio: move VIRTIO_F_NOTIFY_ON_EMPTY into core Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 31/57] virtio-net: adding all queues in .realize() Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 32/57] virtio: device_plugged() can fail Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 33/57] virtio: introduce virtio_get_num_queues() Michael S. Tsirkin
2015-05-31 18:36 ` Michael S. Tsirkin [this message]
2015-05-31 18:36 ` [Qemu-devel] [PULL 35/57] virtio-ccw: validate the number of queues against bus limitation Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 36/57] virtio-s390: introduce virito s390 queue limit Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 37/57] virtio-s390: introduce virtio_s390_device_plugged() Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 38/57] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 39/57] virtio: increase the queue limit to 1024 Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 40/57] i386/pc: pc_basic_device_init(): delegate FDC creation request Michael S. Tsirkin
2015-05-31 18:36 ` [Qemu-devel] [PULL 41/57] i386/pc: '-drive if=floppy' should imply a board-default FDC Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 42/57] i386/pc_q35: don't insist on board FDC if there's no default floppy Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 43/57] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 44/57] acpi: Simplify printing to dynamic string Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 45/57] Add stream ID to MSI write Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 46/57] Extend TPM TIS interface to support TPM 2 Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 47/57] tpm: Probe for connected TPM 1.2 or " Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 48/57] TPM2 ACPI table support Michael S. Tsirkin
2015-06-04 13:57   ` Igor Mammedov
2015-06-05 20:42     ` Stefan Berger
2015-05-31 18:37 ` [Qemu-devel] [PULL 49/57] acpi: add aml_add() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 50/57] acpi: add aml_lless() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 51/57] acpi: add aml_index() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 52/57] acpi: add aml_shiftleft() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 53/57] acpi: add aml_shiftright() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 54/57] acpi: add aml_increment() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 55/57] acpi: add aml_while() term Michael S. Tsirkin
2015-05-31 18:37 ` [Qemu-devel] [PULL 56/57] hw/acpi/aml-build: Fix memory leak Michael S. Tsirkin
2015-05-31 18:38 ` [Qemu-devel] [PULL 57/57] virtio-mmio: ioeventfd support Michael S. Tsirkin
2015-06-01 12:04 ` [Qemu-devel] [PULL 00/57] pc, pci, tpm, virtio enhancements and fixes Peter Maydell
2015-06-01 12:14   ` Michael S. Tsirkin
2015-06-02 14:49   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433097192-8988-35-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).