From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzOoU-0004rA-SF for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:27:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzOoQ-0000nJ-Pn for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:27:30 -0400 Received: from mail-pd0-x235.google.com ([2607:f8b0:400e:c02::235]:34869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzOoQ-0000nB-JQ for qemu-devel@nongnu.org; Mon, 01 Jun 2015 08:27:26 -0400 Received: by pdbnf5 with SMTP id nf5so45536164pdb.2 for ; Mon, 01 Jun 2015 05:27:25 -0700 (PDT) From: Leon Yu Date: Mon, 1 Jun 2015 12:27:12 +0000 Message-Id: <1433161632-5752-1-git-send-email-chianglungyu@gmail.com> Subject: [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Leon Yu , qemu-devel@nongnu.org as comparing boolean with constant 3 is always false. Signed-off-by: Leon Yu --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab..30f2374 100644 --- a/target-arm/op_helper.c +++ b/target-arm/op_helper.c @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome) /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is * a bug in the access function. */ - assert(!arm_is_secure(env) && !arm_current_el(env) == 3); + assert(!arm_is_secure(env) && !(arm_current_el(env) == 3)); target_el = 2; break; case CP_ACCESS_TRAP_EL3: -- 2.1.4