* [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper
@ 2015-06-01 12:27 Leon Yu
2015-06-01 14:20 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Leon Yu @ 2015-06-01 12:27 UTC (permalink / raw)
To: Peter Maydell; +Cc: Leon Yu, qemu-devel
as comparing boolean with constant 3 is always false.
Signed-off-by: Leon Yu <chianglungyu@gmail.com>
---
target-arm/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
index 3f5b9ab..30f2374 100644
--- a/target-arm/op_helper.c
+++ b/target-arm/op_helper.c
@@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome)
/* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is
* a bug in the access function.
*/
- assert(!arm_is_secure(env) && !arm_current_el(env) == 3);
+ assert(!arm_is_secure(env) && !(arm_current_el(env) == 3));
target_el = 2;
break;
case CP_ACCESS_TRAP_EL3:
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper
2015-06-01 12:27 [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper Leon Yu
@ 2015-06-01 14:20 ` Peter Maydell
2015-06-02 14:05 ` Leon Yu
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2015-06-01 14:20 UTC (permalink / raw)
To: Leon Yu; +Cc: QEMU Developers
On 1 June 2015 at 13:27, Leon Yu <chianglungyu@gmail.com> wrote:
> as comparing boolean with constant 3 is always false.
>
> Signed-off-by: Leon Yu <chianglungyu@gmail.com>
> ---
> target-arm/op_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> index 3f5b9ab..30f2374 100644
> --- a/target-arm/op_helper.c
> +++ b/target-arm/op_helper.c
> @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome)
> /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is
> * a bug in the access function.
> */
> - assert(!arm_is_secure(env) && !arm_current_el(env) == 3);
> + assert(!arm_is_secure(env) && !(arm_current_el(env) == 3));
> target_el = 2;
> break;
Yep. There's a fix onlist already:
http://patchwork.ozlabs.org/patch/477597/
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper
2015-06-01 14:20 ` Peter Maydell
@ 2015-06-02 14:05 ` Leon Yu
0 siblings, 0 replies; 3+ messages in thread
From: Leon Yu @ 2015-06-02 14:05 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
Argh, that fix is cleaner and I should have checked patchwork first.
Lesson learned, thanks.
-Leon
On Mon, Jun 1, 2015 at 10:20 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 1 June 2015 at 13:27, Leon Yu <chianglungyu@gmail.com> wrote:
>> as comparing boolean with constant 3 is always false.
>>
>> Signed-off-by: Leon Yu <chianglungyu@gmail.com>
>> ---
>> target-arm/op_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
>> index 3f5b9ab..30f2374 100644
>> --- a/target-arm/op_helper.c
>> +++ b/target-arm/op_helper.c
>> @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome)
>> /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is
>> * a bug in the access function.
>> */
>> - assert(!arm_is_secure(env) && !arm_current_el(env) == 3);
>> + assert(!arm_is_secure(env) && !(arm_current_el(env) == 3));
>> target_el = 2;
>> break;
>
> Yep. There's a fix onlist already:
> http://patchwork.ozlabs.org/patch/477597/
>
> thanks
> -- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-02 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-01 12:27 [Qemu-devel] [PATCH] target-arm: fix incorrect assertion in access_check_cp_reg helper Leon Yu
2015-06-01 14:20 ` Peter Maydell
2015-06-02 14:05 ` Leon Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).