From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzcmZ-0002j3-OV for qemu-devel@nongnu.org; Mon, 01 Jun 2015 23:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzcmY-0008A4-NO for qemu-devel@nongnu.org; Mon, 01 Jun 2015 23:22:27 -0400 From: Fam Zheng Date: Tue, 2 Jun 2015 11:21:52 +0800 Message-Id: <1433215322-23529-4-git-send-email-famz@redhat.com> In-Reply-To: <1433215322-23529-1-git-send-email-famz@redhat.com> References: <1433215322-23529-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v2 03/13] blockdev: Lock BDS during internal snapshot transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Jeff Cody , Stefan Hajnoczi , qemu-block@nongnu.org Signed-off-by: Fam Zheng --- blockdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..fdc5a17 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1356,6 +1356,7 @@ static void internal_snapshot_prepare(BlkTransactionState *common, } /* 4. succeed, mark a snapshot is created */ + bdrv_lock(bs); state->bs = bs; } @@ -1387,6 +1388,9 @@ static void internal_snapshot_clean(BlkTransactionState *common) InternalSnapshotState *state = DO_UPCAST(InternalSnapshotState, common, common); + if (state->bs) { + bdrv_unlock(state->bs); + } if (state->aio_context) { aio_context_release(state->aio_context); } -- 2.4.1