From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yzcml-00037F-4t for qemu-devel@nongnu.org; Mon, 01 Jun 2015 23:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yzcmk-0008EA-ER for qemu-devel@nongnu.org; Mon, 01 Jun 2015 23:22:39 -0400 From: Fam Zheng Date: Tue, 2 Jun 2015 11:21:55 +0800 Message-Id: <1433215322-23529-7-git-send-email-famz@redhat.com> In-Reply-To: <1433215322-23529-1-git-send-email-famz@redhat.com> References: <1433215322-23529-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v2 06/13] blockdev: Lock BDS during blockdev-backup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Jeff Cody , Stefan Hajnoczi , qemu-block@nongnu.org The change is similar to drive-backup in last patch. Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index d7526f6..e112a18 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1667,6 +1667,8 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) return; } aio_context_acquire(state->aio_context); + state->bs = bs; + bdrv_lock(bs); qmp_blockdev_backup(backup->device, backup->target, backup->sync, @@ -1679,7 +1681,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) return; } - state->bs = bs; state->job = state->bs->job; } @@ -1699,6 +1700,7 @@ static void blockdev_backup_clean(BlkTransactionState *common) BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common); if (state->aio_context) { + bdrv_unlock(state->bs); aio_context_release(state->aio_context); } } -- 2.4.1