From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzhCq-0002aK-Bh for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:05:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzhCl-00020O-Jv for qemu-devel@nongnu.org; Tue, 02 Jun 2015 04:05:52 -0400 From: Martin Kletzander Date: Tue, 2 Jun 2015 10:05:29 +0200 Message-Id: <1433232329-14983-1-git-send-email-mkletzan@redhat.com> Subject: [Qemu-devel] [PATCH] arm: Fix invalid assert logic in op_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Peter Maydell Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it according to the comment above as currently the build fails with gcc-5.1.0. Signed-off-by: Martin Kletzander --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index 3f5b9ab5963b..7583ae71217b 100644 --- a/target-arm/op_helper.c +++ b/target-arm/op_helper.c @@ -421,7 +421,7 @@ void HELPER(access_check_cp_reg)(CPUARMState *env, void *rip, uint32_t syndrome) /* Requesting a trap to EL2 when we're in EL3 or S-EL0/1 is * a bug in the access function. */ - assert(!arm_is_secure(env) && !arm_current_el(env) == 3); + assert(!arm_is_secure(env) && arm_current_el(env) != 3); target_el = 2; break; case CP_ACCESS_TRAP_EL3: -- 2.4.2