From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yzijc-0007IF-4h
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:43:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YzijY-0002kz-Vc
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:43:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47711)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YzijY-0002kk-R4
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 05:43:44 -0400
Message-ID: <1433238211.1637.41.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 02 Jun 2015 11:43:31 +0200
In-Reply-To: <20150602102323-mutt-send-email-mst@redhat.com>
References: <556C1F63.1090605@redhat.com>
	<20150601121908-mutt-send-email-mst@redhat.com>
	<556C3757.7080603@redhat.com>
	<20150601124604-mutt-send-email-mst@redhat.com>
	<556C417D.4050707@redhat.com>
	<20150601143447-mutt-send-email-mst@redhat.com>
	<556C5275.7010702@redhat.com>
	<20150601144015-mutt-send-email-mst@redhat.com>
	<556C535B.60307@redhat.com>
	<1433230633.1637.16.camel@nilsson.home.kraxel.org>
	<20150602102323-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs
	via qemu cmdline
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: matt.fleming@intel.com, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, gsomlo@gmail.com, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>

  Hi,

> > I can't see a strong reasons to change things.  The docs clearly
> > recommend to use opt/ prefix to avoid conflicts.  That is fine IMHO.
> > 
> > I don't feel like enforcing that in code, being able to use something
> > else can be useful for debugging/testing purposes.  For example there
> > are some etc/* things seabios looks at which qemu has no support for.
> > One can also supply option roms with the new switch.
> > 
> > cheers,
> >   Gerd
> 
> Well isn't this exactly the problem?
> Once one does, then qemu gains same option rom and things break.

Yea, sure.  "testing/debugging purposes".  I don't mind if that breaks.
When developing stuff I do tricks which can break on
qemu/libvirt/whatever upgrade all the time for all kinds of reasons, for
example because libvirt doesn't support $new_hot_qemu_feature yet.

For production usage better don't do that and stick to the "opt/" prefix
recommendation.  If adding something outside opt/ turns out to be useful
outside testing/debugging we should add a proper qemu cmd line option
for that instead of suggesting users to fiddle with -fw_cfg.  No
question about that.

But I don't think we should break -fw_cfg usage as testing/debugging
tool by enforcing opt/ prefix.

cheers,
  Gerd