qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH V8 04/17] hw/i386: query only for q35/pc when looking for pci host bridge
Date: Tue,  2 Jun 2015 14:22:59 +0300	[thread overview]
Message-ID: <1433244192-27624-5-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1433244192-27624-1-git-send-email-marcel@redhat.com>

Because of the PXB hosts we cannot simply query TYPE_PCI_HOST_BRIDGE anymore.
On i386 arch we only have two pci hosts, so we can look only for them.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/i386/acpi-build.c | 34 +++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 2c7399b..50b93bd 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -240,13 +240,32 @@ static void acpi_get_misc_info(AcpiMiscInfo *info)
     info->applesmc_io_base = applesmc_port();
 }
 
+/*
+ * Because of the PXB hosts we cannot simply query TYPE_PCI_HOST_BRIDGE.
+ * On i386 arch we only have two pci hosts, so we can look only for them.
+ */
+static Object *acpi_get_i386_pci_host(void)
+{
+    PCIHostState *host;
+
+    host = OBJECT_CHECK(PCIHostState,
+                        object_resolve_path("/machine/i440fx", NULL),
+                        TYPE_PCI_HOST_BRIDGE);
+    if (!host) {
+        host = OBJECT_CHECK(PCIHostState,
+                            object_resolve_path("/machine/q35", NULL),
+                            TYPE_PCI_HOST_BRIDGE);
+    }
+
+    return OBJECT(host);
+}
+
 static void acpi_get_pci_info(PcPciInfo *info)
 {
     Object *pci_host;
-    bool ambiguous;
 
-    pci_host = object_resolve_path_type("", TYPE_PCI_HOST_BRIDGE, &ambiguous);
-    g_assert(!ambiguous);
+
+    pci_host = acpi_get_i386_pci_host();
     g_assert(pci_host);
 
     info->w32.begin = object_property_get_int(pci_host,
@@ -957,10 +976,9 @@ build_ssdt(GArray *table_data, GArray *linker,
         {
             Object *pci_host;
             PCIBus *bus = NULL;
-            bool ambiguous;
 
-            pci_host = object_resolve_path_type("", TYPE_PCI_HOST_BRIDGE, &ambiguous);
-            if (!ambiguous && pci_host) {
+            pci_host = acpi_get_i386_pci_host();
+            if (pci_host) {
                 bus = PCI_HOST_BRIDGE(pci_host)->bus;
             }
 
@@ -1272,10 +1290,8 @@ static bool acpi_get_mcfg(AcpiMcfgInfo *mcfg)
 {
     Object *pci_host;
     QObject *o;
-    bool ambiguous;
 
-    pci_host = object_resolve_path_type("", TYPE_PCI_HOST_BRIDGE, &ambiguous);
-    g_assert(!ambiguous);
+    pci_host = acpi_get_i386_pci_host();
     g_assert(pci_host);
 
     o = object_property_get_qobject(pci_host, PCIE_HOST_MCFG_BASE, NULL);
-- 
2.1.0

  parent reply	other threads:[~2015-06-02 11:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 11:22 [Qemu-devel] [PATCH V8 00/17] hw/pc: implement multiple primary busses for pc machines Marcel Apfelbaum
2015-06-02 11:22 ` [Qemu-devel] [PATCH V8 01/17] acpi: add implementation of aml_while() term Marcel Apfelbaum
2015-06-02 11:22 ` [Qemu-devel] [PATCH V8 02/17] hw/pci: made pci_bus_is_root a PCIBusClass method Marcel Apfelbaum
2015-06-02 11:22 ` [Qemu-devel] [PATCH V8 03/17] hw/pci: made pci_bus_num " Marcel Apfelbaum
2015-06-02 11:22 ` Marcel Apfelbaum [this message]
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 05/17] hw/pci: extend PCI config access to support devices behind PXB Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 06/17] hw/acpi: add support for i440fx 'snooping' root busses Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 07/17] hw/apci: add _PRT method for extra PCI " Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 08/17] hw/acpi: add _CRS method for extra " Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 09/17] hw/acpi: remove from root bus 0 the crs resources used by other buses Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 11/17] hw/pci: introduce PCI Expander Bridge (PXB) Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 12/17] hw/pci: inform bios if the system has extra pci root buses Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 13/17] hw/pxb: add map_irq func Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 14/17] hw/pci: add support for NUMA nodes Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 15/17] hw/pxb: add numa_node parameter Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 16/17] apci: fix PXB behaviour if used with unsupported BIOS Marcel Apfelbaum
2015-06-02 11:23 ` [Qemu-devel] [PATCH V8 17/17] docs: Add PXB documentation Marcel Apfelbaum
2015-06-03 16:12 ` [Qemu-devel] [PATCH V8 00/17] hw/pc: implement multiple primary busses for pc machines Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433244192-27624-5-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).