From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yzo3c-0002IA-15
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:24:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yzo3V-0008In-Ur
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:24:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41066)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Yzo3V-0008IP-Pr
	for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:24:41 -0400
Message-ID: <1433258678.8336.2.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 02 Jun 2015 17:24:38 +0200
In-Reply-To: <556D7F7D.9050403@gmail.com>
References: <cover.1433164051.git.DirtY.iCE.hu@gmail.com>
	<ed3d594f52d79c5842910d13639cc47c653191e8.1433164051.git.DirtY.iCE.hu@gmail.com>
	<1433231769.1637.19.camel@nilsson.home.kraxel.org>
	<556D7F7D.9050403@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out
	and init_in
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?K=C5=91v=C3=A1g=C3=B3_Zolt=C3=A1n?= <dirty.ice.hu@gmail.com>
Cc: qemu-devel@nongnu.org

On Di, 2015-06-02 at 12:03 +0200, K=C5=91v=C3=A1g=C3=B3 Zolt=C3=A1n wrote=
:
> 2015-06-02 09:56 keltez=C3=A9ssel, Gerd Hoffmann =C3=ADrta:
> >> -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as)
> >> +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,
> >> +                         void *drv_opaque)
> >>   {
> >>       ALSAVoiceOut *alsa =3D (ALSAVoiceOut *) hw;
> >>       struct alsa_params_req req;
> >> @@ -827,6 +828,8 @@ static int alsa_init_out (HWVoiceOut *hw, struct=
 audsettings *as)
> >>       snd_pcm_t *handle;
> >>       struct audsettings obt_as;
> >>
> >> +    (void) drv_opaque;
> >> +
> >
> > What is the reason for this?
>=20
> To silence compiler warnings about unused variables.

That should not happen for parameters (only for local variables).

> I've seen it around=20
> different places in the code. But if they are just historic remains,=20
> I'll remove them.

Yes, please.

thanks,
  Gerd