qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com,
	Jan Beulich <jbeulich@suse.com>,
	Stefano.Stabellini@eu.citrix.com
Subject: [Qemu-devel] [PULL 08/11] xen/pt: mark all PCIe capability bits read-only
Date: Tue, 2 Jun 2015 16:40:25 +0100	[thread overview]
Message-ID: <1433259628-4611-8-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1506021633010.19838@kaball.uk.xensource.com>

From: Jan Beulich <jbeulich@suse.com>

xen_pt_emu_reg_pcie[]'s PCI_EXP_DEVCAP needs to cover all bits as read-
only to avoid unintended write-back (just a precaution, the field ought
to be read-only in hardware).

This is a preparatory patch for XSA-131.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 hw/xen/xen_pt_config_init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 3833b9e..9f6c00e 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -871,7 +871,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .offset     = PCI_EXP_DEVCAP,
         .size       = 4,
         .init_val   = 0x00000000,
-        .ro_mask    = 0x1FFCFFFF,
+        .ro_mask    = 0xFFFFFFFF,
         .emu_mask   = 0x10000000,
         .init       = xen_pt_common_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,
-- 
1.7.10.4

  parent reply	other threads:[~2015-06-02 15:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 15:39 [Qemu-devel] [PULL 0/11] Xen PCI Passthrough security fixes Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 01/11] xen: properly gate host writes of modified PCI CFG contents Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 02/11] xen: don't allow guest to control MSI mask register Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 03/11] xen/MSI-X: limit error messages Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 04/11] xen/MSI: don't open-code pass-through of enable bit modifications Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 05/11] xen/pt: consolidate PM capability emu_mask Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 06/11] xen/pt: correctly handle PM status bit Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 07/11] xen/pt: split out calculation of throughable mask in PCI config space handling Stefano Stabellini
2015-06-02 15:40 ` Stefano Stabellini [this message]
2015-06-02 15:40 ` [Qemu-devel] [PULL 09/11] xen/pt: mark reserved bits in PCI config space fields Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 10/11] xen/pt: add a few PCI config space field descriptions Stefano Stabellini
2015-06-02 15:40 ` [Qemu-devel] [PULL 11/11] xen/pt: unknown PCI config space fields should be read-only Stefano Stabellini
2015-06-02 16:43 ` [Qemu-devel] [PULL 0/11] Xen PCI Passthrough security fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433259628-4611-8-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).