From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
To: afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com,
borntraeger@de.ibm.com, quintela@redhat.com,
qemu-devel@nongnu.org
Cc: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 3/3] qmp/hmp: Add throttle ratio to query-migrate and info migrate
Date: Tue, 2 Jun 2015 13:46:49 -0400 [thread overview]
Message-ID: <1433267209-9882-4-git-send-email-jjherne@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433267209-9882-1-git-send-email-jjherne@linux.vnet.ibm.com>
Report throttle ratio in info migrate and query-migrate responses when cpu
throttling is active.
Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
---
hmp.c | 5 +++++
migration/migration.c | 5 +++++
qapi-schema.json | 3 ++-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index e17852d..cb3c137 100644
--- a/hmp.c
+++ b/hmp.c
@@ -229,6 +229,11 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
info->xbzrle_cache->overflow);
}
+ if (info->has_x_cpu_throttle_ratio) {
+ monitor_printf(mon, "cpu throttle ratio : %0.2f\n",
+ info->x_cpu_throttle_ratio);
+ }
+
qapi_free_MigrationInfo(info);
qapi_free_MigrationCapabilityStatusList(caps);
}
diff --git a/migration/migration.c b/migration/migration.c
index c9545df..98cc03a 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -263,6 +263,11 @@ MigrationInfo *qmp_query_migrate(Error **errp)
info->disk->total = blk_mig_bytes_total();
}
+ if (cpu_throttle_active(first_cpu)) {
+ info->has_x_cpu_throttle_ratio = true;
+ info->x_cpu_throttle_ratio = cpu_throttle_get_ratio(first_cpu);
+ }
+
get_xbzrle_cache_stats(info);
break;
case MIGRATION_STATUS_COMPLETED:
diff --git a/qapi-schema.json b/qapi-schema.json
index f97ffa1..5e732e0 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -483,7 +483,8 @@
'*total-time': 'int',
'*expected-downtime': 'int',
'*downtime': 'int',
- '*setup-time': 'int'} }
+ '*setup-time': 'int',
+ '*x-cpu-throttle-ratio': 'number'} }
##
# @query-migrate
--
1.9.1
next prev parent reply other threads:[~2015-06-02 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 17:46 [Qemu-devel] [PATCH v2 0/3] migration: Dynamic cpu throttling for auto-converge Jason J. Herne
2015-06-02 17:46 ` [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface Jason J. Herne
2015-06-03 7:56 ` Juan Quintela
2015-06-03 18:02 ` Jason J. Herne
2015-06-03 18:03 ` Dr. David Alan Gilbert
2015-06-03 18:11 ` Jason J. Herne
2015-06-08 19:07 ` Jason J. Herne
2015-06-09 8:06 ` Dr. David Alan Gilbert
2015-06-09 15:14 ` Jason J. Herne
2015-06-10 8:45 ` Dr. David Alan Gilbert
2015-06-10 12:03 ` Jason J. Herne
2015-06-11 6:38 ` Markus Armbruster
2015-06-02 17:46 ` [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for auto-converge Jason J. Herne
2015-06-02 20:08 ` Eric Blake
2015-06-02 17:46 ` Jason J. Herne [this message]
2015-06-02 20:11 ` [Qemu-devel] [PATCH v2 3/3] qmp/hmp: Add throttle ratio to query-migrate and info migrate Eric Blake
2015-06-03 17:45 ` Jason J. Herne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433267209-9882-4-git-send-email-jjherne@linux.vnet.ibm.com \
--to=jjherne@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).