From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH v4 3/4] monitor: Fix failure path for "S" argument type
Date: Tue, 2 Jun 2015 23:28:41 -0400 [thread overview]
Message-ID: <1433302122-27397-4-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1433302122-27397-1-git-send-email-bsd@redhat.com>
The "S" argument is only used with ? and we don't
reach it. Fix it nevertheless.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 6777cbe..cbc3cc6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4069,7 +4069,7 @@ static QDict *monitor_parse_arguments(Monitor *mon,
if (len <= 0) {
monitor_printf(mon, "%s: string expected\n",
cmd->name);
- break;
+ goto fail;
}
qdict_put(qdict, key, qstring_from_str(p));
p += len;
--
2.1.0
next prev parent reply other threads:[~2015-06-03 3:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 3:28 [Qemu-devel] [PATCH v4 0/4] monitor: suggest running "help" for command errors Bandan Das
2015-06-03 3:28 ` [Qemu-devel] [PATCH v4 1/4] monitor: cleanup parsing of cmd name and cmd arguments Bandan Das
2015-06-03 11:26 ` Markus Armbruster
2015-06-03 3:28 ` [Qemu-devel] [PATCH v4 2/4] When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP Bandan Das
2015-06-03 11:30 ` Markus Armbruster
2015-06-03 3:28 ` Bandan Das [this message]
2015-06-03 11:32 ` [Qemu-devel] [PATCH v4 3/4] monitor: Fix failure path for "S" argument type Markus Armbruster
2015-06-03 3:28 ` [Qemu-devel] [PATCH v4 4/4] monitor: remove debug prints Bandan Das
2015-06-03 11:33 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433302122-27397-4-git-send-email-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).