From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzzMt-0000Zk-2o for qemu-devel@nongnu.org; Tue, 02 Jun 2015 23:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzzMq-0000Qe-NI for qemu-devel@nongnu.org; Tue, 02 Jun 2015 23:29:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzzMq-0000Qa-J7 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 23:29:24 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 46795347A6B for ; Wed, 3 Jun 2015 03:29:24 +0000 (UTC) From: Bandan Das Date: Tue, 2 Jun 2015 23:28:41 -0400 Message-Id: <1433302122-27397-4-git-send-email-bsd@redhat.com> In-Reply-To: <1433302122-27397-1-git-send-email-bsd@redhat.com> References: <1433302122-27397-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH v4 3/4] monitor: Fix failure path for "S" argument type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com The "S" argument is only used with ? and we don't reach it. Fix it nevertheless. Signed-off-by: Bandan Das --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 6777cbe..cbc3cc6 100644 --- a/monitor.c +++ b/monitor.c @@ -4069,7 +4069,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, if (len <= 0) { monitor_printf(mon, "%s: string expected\n", cmd->name); - break; + goto fail; } qdict_put(qdict, key, qstring_from_str(p)); p += len; -- 2.1.0