From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/9] vl: Report failure to sandbox at most once
Date: Wed, 3 Jun 2015 11:17:48 +0200 [thread overview]
Message-ID: <1433323076-9264-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1433323076-9264-1-git-send-email-armbru@redhat.com>
It's reported once per -sandbox on. Stop on the first failure, like
we do for other options.
Not fixed: "-sandbox on -sandbox off" should leave the sandbox off.
It doesn't.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 1d4c089..04a6066 100644
--- a/vl.c
+++ b/vl.c
@@ -3780,7 +3780,7 @@ int main(int argc, char **argv, char **envp)
exit(1);
}
- if (qemu_opts_foreach(qemu_find_opts("sandbox"), parse_sandbox, NULL, 0)) {
+ if (qemu_opts_foreach(qemu_find_opts("sandbox"), parse_sandbox, NULL, 1)) {
exit(1);
}
--
1.9.3
next prev parent reply other threads:[~2015-06-03 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 9:17 [Qemu-devel] [PATCH v2 0/9] Miscellaneous error reporting improvements Markus Armbruster
2015-06-03 9:17 ` Markus Armbruster [this message]
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 2/9] vl: Print -device help at most once Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 3/9] vl: Fail right after first bad -object Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 4/9] QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 5/9] QemuOpts: Convert qemu_opts_foreach() to Error Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach() Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 7/9] QemuOpts: Drop qemu_opt_foreach() parameter abort_on_failure Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 8/9] QemuOpts: Convert qemu_opt_foreach() to Error Markus Armbruster
2015-06-03 9:17 ` [Qemu-devel] [PATCH v2 9/9] vhost-user: Improve -netdev/netdev_add/-net/... error reporting Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433323076-9264-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).