From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com,
Meghana Cheripady <meghana.cheripady@avagotech.com>,
Padmanabh Ratnakar <padmanabh.ratnakar@avagotech.com>
Subject: [Qemu-devel] [PULL 06/21] rdma: Fix qemu crash when IPv6 address is used for migration
Date: Wed, 3 Jun 2015 14:05:42 +0200 [thread overview]
Message-ID: <1433333157-9939-7-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1433333157-9939-1-git-send-email-quintela@redhat.com>
From: Padmanabh Ratnakar <padmanabh.ratnakar@avagotech.com>
Qemu crashes when IPv6 address is specified for migration and access
to any RDMA uverbs device available on the system is blocked using cgroups.
Fix the crash by checking the return value of ibv_open_device routine.
Signed-off-by: Meghana Cheripady <meghana.cheripady@avagotech.com>
Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@avagotech.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/rdma.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index 77e3444..3671903 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -790,6 +790,13 @@ static int qemu_rdma_broken_ipv6_kernel(Error **errp, struct ibv_context *verbs)
for (x = 0; x < num_devices; x++) {
verbs = ibv_open_device(dev_list[x]);
+ if (!verbs) {
+ if (errno == EPERM) {
+ continue;
+ } else {
+ return -EINVAL;
+ }
+ }
if (ibv_query_port(verbs, 1, &port_attr)) {
ibv_close_device(verbs);
--
2.4.1
next prev parent reply other threads:[~2015-06-03 12:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 12:05 [Qemu-devel] [PULL 00/21] Migration pull request Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 01/21] migration: move ram stuff to migration/ram Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 02/21] migration: move savevm.c inside migration/ Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 03/21] migration: Add myself to the copyright list of both files Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 04/21] migration: reduce include files Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 05/21] arch_init: Clean up the duplicate variable 'len' defining in ram_load() Juan Quintela
2015-06-03 12:05 ` Juan Quintela [this message]
2015-06-03 12:05 ` [Qemu-devel] [PULL 07/21] migration: Remove duplicated assignment of SETUP status Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 08/21] migration: create savevm_state Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 09/21] migration: Use normal VMStateDescriptions for Subsections Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 10/21] Add qemu_get_counted_string to read a string prefixed by a count byte Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 11/21] Split header writing out of qemu_savevm_state_begin Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 12/21] qemu_ram_foreach_block: pass up error value, and down the ramblock name Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 13/21] Create MigrationIncomingState Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 14/21] Move copy out of qemu_peek_buffer Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 15/21] Move loadvm_handlers into MigrationIncomingState Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 16/21] Merge section header writing Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 17/21] Disable section footers on older machine types Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 18/21] Add a protective section footer Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 19/21] Teach analyze-migration.py about section footers Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 20/21] Rename RDMA structures to make destination clear Juan Quintela
2015-06-03 12:05 ` [Qemu-devel] [PULL 21/21] Remove unneeded memset Juan Quintela
2015-06-04 11:48 ` [Qemu-devel] [PULL 00/21] Migration pull request Peter Maydell
2015-06-04 13:01 ` Juan Quintela
-- strict thread matches above, loose matches on Subject: below --
2015-06-12 5:03 [Qemu-devel] [PULL v2 00/21] migration " Juan Quintela
2015-06-12 5:03 ` [Qemu-devel] [PULL 06/21] rdma: Fix qemu crash when IPv6 address is used for migration Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433333157-9939-7-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=meghana.cheripady@avagotech.com \
--cc=padmanabh.ratnakar@avagotech.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).