* [Qemu-devel] [PATCH] Print error when failing to load PCI config data
@ 2015-06-03 16:58 Dr. David Alan Gilbert (git)
2015-06-04 10:49 ` Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2015-06-03 16:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mst
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
When loading migration fails due to a disagreement about
PCI config data we don't currently get any errors explaining
that was the cause of the problem or which byte in the config
data was at fault.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/pci/pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 48f19a3..3afab6b 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -398,6 +398,10 @@ static int get_pci_config_device(QEMUFile *f, void *pv, size_t size)
for (i = 0; i < size; ++i) {
if ((config[i] ^ s->config[i]) &
s->cmask[i] & ~s->wmask[i] & ~s->w1cmask[i]) {
+ error_report("%s: Bad config data: i=0x%x read: %x device: %x "
+ "cmask: %x wmask: %x w1cmask:%x", __func__,
+ i, config[i], s->config[i],
+ s->cmask[i], s->wmask[i], s->w1cmask[i]);
g_free(config);
return -EINVAL;
}
--
2.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Print error when failing to load PCI config data
2015-06-03 16:58 [Qemu-devel] [PATCH] Print error when failing to load PCI config data Dr. David Alan Gilbert (git)
@ 2015-06-04 10:49 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2015-06-04 10:49 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel; +Cc: qemu-trivial, mst
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-04 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-03 16:58 [Qemu-devel] [PATCH] Print error when failing to load PCI config data Dr. David Alan Gilbert (git)
2015-06-04 10:49 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).