From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0FbT-0007zo-JP for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:49:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0FbS-00087A-A0 for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:49:35 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:41847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0FbS-00086v-09 for qemu-devel@nongnu.org; Wed, 03 Jun 2015 16:49:34 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Wed, 3 Jun 2015 22:45:49 +0200 Message-Id: <1433364350-19380-16-git-send-email-hpoussin@reactos.org> In-Reply-To: <1433364350-19380-1-git-send-email-hpoussin@reactos.org> References: <1433364350-19380-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 15/16] net/dp8393x: fix hardware reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Leon Alrae , Aurelien Jarno Documentation is not clear of what happens when doing a hardware reset, but firmware expect all registers to be zero unless specified otherwise. This fixes reboot on MIPS Magnum. Signed-off-by: Herv=C3=A9 Poussineau Reviewed-by: Aurelien Jarno --- hw/net/dp8393x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index ff633f7..cd889bc 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -786,6 +786,7 @@ static void dp8393x_reset(DeviceState *dev) dp8393xState *s =3D DP8393X(dev); timer_del(s->watchdog); =20 + memset(s->regs, 0, sizeof(s->regs)); s->regs[SONIC_CR] =3D SONIC_CR_RST | SONIC_CR_STP | SONIC_CR_RXDIS; s->regs[SONIC_DCR] &=3D ~(SONIC_DCR_EXBUS | SONIC_DCR_LBR); s->regs[SONIC_RCR] &=3D ~(SONIC_RCR_LB0 | SONIC_RCR_LB1 | SONIC_RCR_= BRD | SONIC_RCR_RNT); --=20 2.1.4