From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"Leon Alrae" <leon.alrae@imgtec.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v3 08/16] net/dp8393x: always calculate proper checksums
Date: Wed, 3 Jun 2015 22:45:42 +0200 [thread overview]
Message-ID: <1433364350-19380-9-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1433364350-19380-1-git-send-email-hpoussin@reactos.org>
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
---
hw/net/dp8393x.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 2297231..093f0cc 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -21,16 +21,10 @@
#include "qemu/timer.h"
#include "net/net.h"
#include "hw/mips/mips.h"
+#include <zlib.h>
//#define DEBUG_SONIC
-/* Calculate CRCs properly on Rx packets */
-#define SONIC_CALCULATE_RXCRC
-
-#if defined(SONIC_CALCULATE_RXCRC)
-/* For crc32 */
-#include <zlib.h>
-#endif
#ifdef DEBUG_SONIC
#define DPRINTF(fmt, ...) \
@@ -764,11 +758,7 @@ static ssize_t nic_receive(NetClientState *nc, const uint8_t * buf, size_t size)
s->regs[SONIC_TRBA0] = s->regs[SONIC_CRBA0];
/* Calculate the ethernet checksum */
-#ifdef SONIC_CALCULATE_RXCRC
checksum = cpu_to_le32(crc32(0, buf, rx_len));
-#else
- checksum = 0;
-#endif
/* Put packet into RBA */
DPRINTF("Receive packet at %08x\n", (s->regs[SONIC_CRBA1] << 16) | s->regs[SONIC_CRBA0]);
--
2.1.4
next prev parent reply other threads:[~2015-06-03 20:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 20:45 [Qemu-devel] [PATCH v3 00/16] net/dp8393x and dma/rc4030 improvements Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 01/16] mips jazz: compile only in 64 bit Hervé Poussineau
2015-06-03 21:00 ` Aurelien Jarno
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 02/16] dma/rc4030: create custom DMA address space Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 03/16] dma/rc4030: use AddressSpace and address_space_rw in users Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 04/16] dma/rc4030: do not use old_mmio accesses Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 05/16] dma/rc4030: document register at offset 0x210 Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 06/16] dma/rc4030: use trace events instead of custom logging Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 07/16] dma/rc4030: convert to QOM Hervé Poussineau
2015-06-03 20:45 ` Hervé Poussineau [this message]
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 09/16] net/dp8393x: do not use old_mmio accesses Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 10/16] net/dp8393x: use dp8393x_ prefix for all functions Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 11/16] net/dp8393x: QOM'ify Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 12/16] net/dp8393x: add PROM to store MAC address Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 13/16] net/dp8393x: add load/save support Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 14/16] net/dp8393x: correctly reset in_use field Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 15/16] net/dp8393x: fix hardware reset Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 16/16] [RFC] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers Hervé Poussineau
2015-06-10 12:00 ` Leon Alrae
2015-06-10 19:37 ` Hervé Poussineau
2015-06-10 20:20 ` Peter Maydell
2015-06-10 20:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433364350-19380-9-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).