From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0FvN-0001Sy-KU for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0FvI-0007sJ-8h for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:10:09 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:40079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0FvH-0007pb-Rj for qemu-devel@nongnu.org; Wed, 03 Jun 2015 17:10:04 -0400 From: Aurelien Jarno Date: Wed, 3 Jun 2015 23:09:41 +0200 Message-Id: <1433365796-1118-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433365796-1118-1-git-send-email-aurelien@aurel32.net> References: <1433365796-1118-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2 01/16] target-s390x: fix exception for invalid operation code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexander Graf , Aurelien Jarno , Richard Henderson When an operation code is not recognized (ie invalid instruction) an operation exception should be generated instead of a specification exception. The latter is for valid opcode, with invalid operands or modifiers. This give a very basic GDB support in the guest, as it uses the invalid opcode 0x0001 to generate a trap. Cc: Alexander Graf Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- target-s390x/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index d508bc2..c7ebd21 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -320,7 +320,7 @@ static void gen_program_exception(DisasContext *s, int code) static inline void gen_illegal_opcode(DisasContext *s) { - gen_program_exception(s, PGM_SPECIFICATION); + gen_program_exception(s, PGM_OPERATION); } #ifndef CONFIG_USER_ONLY -- 2.1.4