qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org,
	David Gibson <david@gibson.dropbear.id.au>,
	qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PULL 24/40] spapr: add rtas_st_buffer_direct() helper
Date: Wed,  3 Jun 2015 23:45:25 +0200	[thread overview]
Message-ID: <1433367941-119488-25-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1433367941-119488-1-git-send-email-agraf@suse.de>

From: Michael Roth <mdroth@linux.vnet.ibm.com>

This is similar to the existing rtas_st_buffer(), but for cases
where the guest is not expecting a length-encoded byte array.
Namely, for calls where a "work area" buffer is used to pass
around arbitrary fields/data.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 include/hw/ppc/spapr.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 8810911..65ef7dd 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -464,6 +464,13 @@ static inline void rtas_st(target_ulong phys, int n, uint32_t val)
     stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4*n), val);
 }
 
+static inline void rtas_st_buffer_direct(target_ulong phys,
+                                         target_ulong phys_len,
+                                         uint8_t *buffer, uint16_t buffer_len)
+{
+    cpu_physical_memory_write(ppc64_phys_to_real(phys), buffer,
+                              MIN(buffer_len, phys_len));
+}
 
 static inline void rtas_st_buffer(target_ulong phys, target_ulong phys_len,
                                   uint8_t *buffer, uint16_t buffer_len)
@@ -473,8 +480,7 @@ static inline void rtas_st_buffer(target_ulong phys, target_ulong phys_len,
     }
     stw_be_phys(&address_space_memory,
                 ppc64_phys_to_real(phys), buffer_len);
-    cpu_physical_memory_write(ppc64_phys_to_real(phys + 2),
-                              buffer, MIN(buffer_len, phys_len - 2));
+    rtas_st_buffer_direct(phys + 2, phys_len - 2, buffer, buffer_len);
 }
 
 typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, sPAPREnvironment *spapr,
-- 
1.8.1.4

  parent reply	other threads:[~2015-06-03 21:45 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 21:45 [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03 Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 01/40] macio: Convert to realize() Alexander Graf
2015-06-03 21:53   ` Peter Maydell
2015-06-03 22:00     ` Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 02/40] dtc: Update dtc / libfdt submodule to version 1.4.0 Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 03/40] configure: Check for libfdt " Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 04/40] spapr_pci: Fix unsafe signed/unsigned comparisons Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 05/40] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 06/40] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 07/40] spapr_pci: Introduce a liobn number generating macros Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 08/40] spapr_vio: " Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 09/40] spapr_pci: Define default DMA window size as a macro Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 10/40] spapr_iommu: Add separate trace points for PCI DMA operations Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 11/40] spapr_pci: Make find_phb()/find_dev() public Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 12/40] spapr_iommu: Make spapr_tce_find_by_liobn() public Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 13/40] spapr_pci: Rework device-tree rendering Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 14/40] spapr_iommu: Give unique QOM name to TCE table Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 15/40] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 16/40] pseries: Add pseries-2.4 machine type Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 17/40] hw/ppc/spapr: Fix error message when firmware could not be loaded Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 18/40] hw/ppc/spapr: Use error_report() instead of hw_error() Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 19/40] docs: add sPAPR hotplug/dynamic-reconfiguration documentation Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 20/40] spapr_drc: initial implementation of sPAPRDRConnector device Alexander Graf
2015-07-09 14:16   ` Paolo Bonzini
2015-06-03 21:45 ` [Qemu-devel] [PULL 21/40] spapr_rtas: add get/set-power-level RTAS interfaces Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 22/40] spapr_rtas: add set-indicator RTAS interface Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 23/40] spapr_rtas: add get-sensor-state " Alexander Graf
2015-06-03 21:45 ` Alexander Graf [this message]
2015-06-03 21:45 ` [Qemu-devel] [PULL 25/40] spapr_rtas: add ibm, configure-connector " Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 26/40] spapr_events: re-use EPOW event infrastructure for hotplug events Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 27/40] spapr_events: event-scan RTAS interface Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 28/40] spapr_drc: add spapr_drc_populate_dt() Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 29/40] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 30/40] spapr_pci: create DRConnectors for each PCI slot during PHB realize Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 31/40] pci: make pci_bar useable outside pci.c Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 32/40] spapr_pci: enable basic hotplug operations Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 33/40] spapr_pci: emit hotplug add/remove events during hotplug Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 34/40] machine: add default_ram_size to machine class Alexander Graf
2015-06-05  7:27   ` Laurent Desnogues
2015-06-03 21:45 ` [Qemu-devel] [PULL 35/40] spapr: override default ram size to 512MB Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 36/40] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 37/40] Add David Gibson for sPAPR in MAINTAINERS file Alexander Graf
2015-11-18 20:46   ` Andreas Färber
2015-11-18 20:51     ` Eric Blake
2015-11-18 20:58       ` Andreas Färber
2015-06-03 21:45 ` [Qemu-devel] [PULL 38/40] tci: do not use CPUArchState in tcg-target.h Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 39/40] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS Alexander Graf
2015-06-03 21:45 ` [Qemu-devel] [PULL 40/40] softmmu: support up to 12 MMU modes Alexander Graf
2015-06-04 17:28 ` [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03 Peter Maydell
2015-06-05 13:33 ` Peter Maydell
2015-06-05 14:35   ` Paolo Bonzini
2015-06-05 14:40     ` Peter Maydell
2015-06-05 15:02       ` Paolo Bonzini
2015-06-05 15:08         ` Peter Maydell
2015-06-05 15:20           ` Paolo Bonzini
2015-06-05 15:45             ` Peter Maydell
2015-06-05 15:55               ` [Qemu-devel] undefined behavior of signed left shifts (was Re: [PULL 00/40] ppc patch queue 2015-06-03) Paolo Bonzini
2015-06-05 17:21                 ` Joseph Myers
2015-06-05 17:33                 ` Peter Maydell
2015-07-21 11:42             ` [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03 Peter Maydell
2015-07-21 23:32               ` Michael Roth
2015-06-05 15:24   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433367941-119488-25-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).