From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0HJ6-00067o-GG for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0HJ5-0008M6-HO for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0HJ5-0008M0-CZ for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:43 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0AE30C1F10 for ; Wed, 3 Jun 2015 22:38:43 +0000 (UTC) From: Bandan Das Date: Wed, 3 Jun 2015 18:38:07 -0400 Message-Id: <1433371090-11781-2-git-send-email-bsd@redhat.com> In-Reply-To: <1433371090-11781-1-git-send-email-bsd@redhat.com> References: <1433371090-11781-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH v5 1/4] monitor: remove debug prints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com The preferred solution is to use tracepoints and there is good chance of bitrot with the debug prints not being enabled at compile time. Remove them. Suggested-by: Markus Armbruster Signed-off-by: Bandan Das Reviewed-by: Markus Armbruster --- monitor.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/monitor.c b/monitor.c index b2561e1..cc4e7d1 100644 --- a/monitor.c +++ b/monitor.c @@ -81,9 +81,6 @@ #endif #include "hw/lm32/lm32_pic.h" -//#define DEBUG -//#define DEBUG_COMPLETION - /* * Supported types: * @@ -3707,10 +3704,6 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, char buf[1024]; char *key; -#ifdef DEBUG - monitor_printf(mon, "command='%s', start='%d'\n", cmdline, start); -#endif - /* extract the command name */ p = get_command_name(cmdline + start, cmdname, sizeof(cmdname)); if (!p) @@ -4189,10 +4182,7 @@ static void file_completion(Monitor *mon, const char *input) path[input_path_len] = '\0'; pstrcpy(file_prefix, sizeof(file_prefix), p + 1); } -#ifdef DEBUG_COMPLETION - monitor_printf(mon, "input='%s' path='%s' prefix='%s'\n", - input, path, file_prefix); -#endif + ffs = opendir(path); if (!ffs) return; @@ -4770,14 +4760,6 @@ static void monitor_find_completion(void *opaque, if (parse_cmdline(cmdline, &nb_args, args) < 0) { return; } -#ifdef DEBUG_COMPLETION - { - int i; - for (i = 0; i < nb_args; i++) { - monitor_printf(mon, "arg%d = '%s'\n", i, args[i]); - } - } -#endif /* if the line ends with a space, it means we want to complete the next arg */ -- 2.1.0