From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0HJF-0006Sn-Pn for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0HJC-0008OP-Ky for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0HJC-0008OH-Gi for qemu-devel@nongnu.org; Wed, 03 Jun 2015 18:38:50 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 26B4FCA62C for ; Wed, 3 Jun 2015 22:38:50 +0000 (UTC) From: Bandan Das Date: Wed, 3 Jun 2015 18:38:10 -0400 Message-Id: <1433371090-11781-5-git-send-email-bsd@redhat.com> In-Reply-To: <1433371090-11781-1-git-send-email-bsd@redhat.com> References: <1433371090-11781-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH v5 4/4] monitor: Fix failure path for "S" argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com Since the "S" argument type is only used with the "?" flag, the bug can't bite. Signed-off-by: Bandan Das Reviewed-by: Markus Armbruster --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 640c05c..5a18844 100644 --- a/monitor.c +++ b/monitor.c @@ -4062,7 +4062,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, if (len <= 0) { monitor_printf(mon, "%s: string expected\n", cmd->name); - break; + goto fail; } qdict_put(qdict, key, qstring_from_str(p)); p += len; -- 2.1.0