From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Ouu-0000EQ-Ua for qemu-devel@nongnu.org; Thu, 04 Jun 2015 02:46:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0Ouu-0004mD-2i for qemu-devel@nongnu.org; Thu, 04 Jun 2015 02:46:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0Out-0004lv-Tu for qemu-devel@nongnu.org; Thu, 04 Jun 2015 02:46:16 -0400 From: Fam Zheng Date: Thu, 4 Jun 2015 14:45:22 +0800 Message-Id: <1433400324-7358-12-git-send-email-famz@redhat.com> In-Reply-To: <1433400324-7358-1-git-send-email-famz@redhat.com> References: <1433400324-7358-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v4 11/13] xen_backend: Remove unused error handling of qemu_set_fd_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Jason Wang , Vincenzo Maffione , Stefan Hajnoczi , Paolo Bonzini , Giuseppe Lettieri , Luigi Rizzo The function cannot fail, so the check is superfluous. Signed-off-by: Fam Zheng --- hw/xen/xen_backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index b2cb22b..2510e2e 100644 --- a/hw/xen/xen_backend.c +++ b/hw/xen/xen_backend.c @@ -714,9 +714,7 @@ int xen_be_init(void) return -1; } - if (qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL) < 0) { - goto err; - } + qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL); if (xen_xc == XC_HANDLER_INITIAL_VALUE) { /* Check if xen_init() have been called */ -- 2.4.2