qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v4 4/8] target-sh4: optimize subc using sub2
Date: Thu,  4 Jun 2015 21:51:16 +0200	[thread overview]
Message-ID: <1433447480-30848-5-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1433447480-30848-1-git-send-email-aurelien@aurel32.net>

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 target-sh4/translate.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/target-sh4/translate.c b/target-sh4/translate.c
index 5c90fe3..b8abfd5 100644
--- a/target-sh4/translate.c
+++ b/target-sh4/translate.c
@@ -880,19 +880,15 @@ static void _decode_opc(DisasContext * ctx)
 	return;
     case 0x300a:		/* subc Rm,Rn */
         {
-            TCGv t0, t1, t2;
-            t0 = tcg_temp_new();
+            TCGv t0, t1;
+            t0 = tcg_const_tl(0);
             t1 = tcg_temp_new();
-            tcg_gen_sub_i32(t1, REG(B11_8), REG(B7_4));
-            tcg_gen_sub_i32(t0, t1, cpu_sr_t);
-            t2 = tcg_temp_new();
-            tcg_gen_setcond_i32(TCG_COND_LTU, t2, REG(B11_8), t1);
-            tcg_gen_setcond_i32(TCG_COND_LTU, t1, t1, t0);
-            tcg_gen_or_i32(cpu_sr_t, t1, t2);
-            tcg_temp_free(t2);
-            tcg_temp_free(t1);
-            tcg_gen_mov_i32(REG(B11_8), t0);
+            tcg_gen_add2_i32(t1, cpu_sr_t, cpu_sr_t, t0, REG(B7_4), t0);
+            tcg_gen_sub2_i32(REG(B11_8), cpu_sr_t,
+                             REG(B11_8), t0, t1, cpu_sr_t);
+            tcg_gen_andi_i32(cpu_sr_t, cpu_sr_t, 1);
             tcg_temp_free(t0);
+            tcg_temp_free(t1);
         }
 	return;
     case 0x300b:		/* subv Rm,Rn */
-- 
2.1.4

  parent reply	other threads:[~2015-06-04 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 19:51 [Qemu-devel] [PATCH v4 0/8] target-sh4: optimizations and cleanups Aurelien Jarno
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 1/8] target-sh4: use bit number for SR constants Aurelien Jarno
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 2/8] target-sh4: Split out T from SR Aurelien Jarno
2015-06-09 14:15   ` Richard Henderson
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 3/8] target-sh4: optimize addc using add2 Aurelien Jarno
2015-06-09 14:15   ` Richard Henderson
2015-06-04 19:51 ` Aurelien Jarno [this message]
2015-06-09 14:16   ` [Qemu-devel] [PATCH v4 4/8] target-sh4: optimize subc using sub2 Richard Henderson
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 5/8] target-sh4: optimize negc using add2 and sub2 Aurelien Jarno
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 6/8] target-sh4: split out Q and M from of SR and optimize div1 Aurelien Jarno
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 7/8] target-sh4: factorize fmov implementation Aurelien Jarno
2015-06-04 19:51 ` [Qemu-devel] [PATCH v4 8/8] target-sh4: remove dead code Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433447480-30848-5-git-send-email-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).