From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0bCq-00079P-Oo for qemu-devel@nongnu.org; Thu, 04 Jun 2015 15:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0bCp-0006fN-5B for qemu-devel@nongnu.org; Thu, 04 Jun 2015 15:53:36 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:45507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0bCo-0006et-Rn for qemu-devel@nongnu.org; Thu, 04 Jun 2015 15:53:34 -0400 From: Aurelien Jarno Date: Thu, 4 Jun 2015 21:53:24 +0200 Message-Id: <1433447607-31184-3-git-send-email-aurelien@aurel32.net> In-Reply-To: <1433447607-31184-1-git-send-email-aurelien@aurel32.net> References: <1433447607-31184-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v1 2/5] tcg/optimize: remove opc argument from tcg_opt_gen_mov List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Richard Henderson We can get the opcode using the TCGOp pointer. It needs to be dereferenced, but it's anyway done a few lines below to write the new value. Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0bfc9a5..db15976 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -194,9 +194,9 @@ static bool temps_are_copies(TCGArg arg1, TCGArg arg2) } static void tcg_opt_gen_mov(TCGContext *s, TCGOp *op, TCGArg *args, - TCGOpcode old_op, TCGArg dst, TCGArg src) + TCGArg dst, TCGArg src) { - TCGOpcode new_op = op_to_mov(old_op); + TCGOpcode new_op = op_to_mov(op->opc); tcg_target_ulong mask; op->opc = new_op; @@ -791,7 +791,7 @@ static void tcg_constant_folding(TCGContext *s) if (temps_are_copies(args[0], args[1])) { tcg_op_remove(s, op); } else { - tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]); + tcg_opt_gen_mov(s, op, args, args[0], args[1]); } continue; default: @@ -950,7 +950,7 @@ static void tcg_constant_folding(TCGContext *s) if (temps_are_copies(args[0], args[1])) { tcg_op_remove(s, op); } else if (temps[args[1]].state != TCG_TEMP_CONST) { - tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]); + tcg_opt_gen_mov(s, op, args, args[0], args[1]); } else { tcg_opt_gen_movi(s, op, args, args[0], temps[args[1]].val); @@ -982,7 +982,7 @@ static void tcg_constant_folding(TCGContext *s) if (temps_are_copies(args[0], args[1])) { tcg_op_remove(s, op); } else if (temps[args[1]].state != TCG_TEMP_CONST) { - tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]); + tcg_opt_gen_mov(s, op, args, args[0], args[1]); } else { tcg_opt_gen_movi(s, op, args, args[0], temps[args[1]].val); @@ -1018,7 +1018,7 @@ static void tcg_constant_folding(TCGContext *s) break; } if (temps[args[1]].state != TCG_TEMP_CONST) { - tcg_opt_gen_mov(s, op, args, opc, args[0], args[1]); + tcg_opt_gen_mov(s, op, args, args[0], args[1]); break; } /* Source argument is constant. Rewrite the operation and @@ -1124,7 +1124,7 @@ static void tcg_constant_folding(TCGContext *s) tcg_opt_gen_movi(s, op, args, args[0], temps[args[4-tmp]].val); } else { - tcg_opt_gen_mov(s, op, args, opc, args[0], args[4-tmp]); + tcg_opt_gen_mov(s, op, args, args[0], args[4-tmp]); } break; } -- 2.1.4