From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0cyA-0008GA-G9 for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0cy9-0002yU-2p for qemu-devel@nongnu.org; Thu, 04 Jun 2015 17:46:34 -0400 From: John Snow Date: Thu, 4 Jun 2015 17:46:12 -0400 Message-Id: <1433454372-16356-11-git-send-email-jsnow@redhat.com> In-Reply-To: <1433454372-16356-1-git-send-email-jsnow@redhat.com> References: <1433454372-16356-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v5 10/10] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, Kashyap Chamarthy , John Snow , qemu-devel@nongnu.org, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync abort block-dirty-bitmap-add block-dirty-bitmap-clear Signed-off-by: Kashyap Chamarthy Reviewed-by: Eric Blake Reviewed-by: Max Reitz Signed-off-by: John Snow --- qmp-commands.hx | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 14e109e..a6029a2 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1238,11 +1238,22 @@ SQMP transaction ----------- -Atomically operate on one or more block devices. The only supported operations -for now are drive-backup, internal and external snapshotting. A list of -dictionaries is accepted, that contains the actions to be performed. -If there is any failure performing any of the operations, all operations -for the group are abandoned. +Atomically operate on one or more block devices. Operations that are +currently supported: + + - drive-backup + - blockdev-backup + - blockdev-snapshot-sync + - blockdev-snapshot-internal-sync + - abort + - block-dirty-bitmap-add + - block-dirty-bitmap-clear + +Refer to the qemu/qapi-schema.json file for minimum required QEMU +versions for these operations. A list of dictionaries is accepted, +that contains the actions to be performed. If there is any failure +performing any of the operations, all operations for the group are +abandoned. For external snapshots, the dictionary contains the device, the file to use for the new snapshot, and the format. The default format, if not specified, is -- 2.1.0