From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z0pNl-000572-Ai
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 07:01:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z0pNh-0001ek-Av
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 07:01:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z0pNh-0001eZ-5m
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 07:01:45 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id B4DFB373BC1
	for <qemu-devel@nongnu.org>; Fri,  5 Jun 2015 11:01:44 +0000 (UTC)
Message-ID: <1433502102.4142.11.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 05 Jun 2015 13:01:42 +0200
In-Reply-To: <55717802.9000707@redhat.com>
References: <1432894036-28513-1-git-send-email-kraxel@redhat.com>
	<1432894036-28513-5-git-send-email-kraxel@redhat.com>
	<55717802.9000707@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 4/5] gtk: add opengl support, using egl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Fr, 2015-06-05 at 12:20 +0200, Paolo Bonzini wrote:
> 
> On 29/05/2015 12:07, Gerd Hoffmann wrote:
> > This adds opengl rendering support to the gtk ui, using egl.
> > It's off by default for now, use 'qemu -display gtk,gl=on'
> > to play with this.
> > 
> > Note that gtk got native opengl support with release 3.16.
> > There most likely will be a separate implementation for 3.16+,
> > using the native gtk opengl support.  This patch covers older
> > versions (and for the time being 3.16 too, hopefully without
> > rendering quirks).
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> This unfortunately breaks "-device help" if you do not have an X11
> connection.  gtk_init exits the program.

Ah, *this* is where the libvirt breakage comes from.  Was about to
bisect that one, can stop now ;)

I'll have a look ASAP.

cheers,
  Gerd