From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0tM4-0001n6-Ek for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0tM3-0007Sw-Eb for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:16:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0tM3-0007Qy-1y for qemu-devel@nongnu.org; Fri, 05 Jun 2015 11:16:19 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id C4C352D1253 for ; Fri, 5 Jun 2015 15:16:18 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-29.ams2.redhat.com [10.36.112.29]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t55FG4kJ012808 for ; Fri, 5 Jun 2015 11:16:17 -0400 From: Paolo Bonzini Date: Fri, 5 Jun 2015 17:15:08 +0200 Message-Id: <1433517363-32335-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1433517363-32335-1-git-send-email-pbonzini@redhat.com> References: <1433517363-32335-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 07/62] g364fb: remove pointless call to memory_region_set_coalescing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Coalescing work on MMIO, not RAM, thus this call has no effect. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/display/g364fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 46f7b41..6543f2f 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -489,7 +489,6 @@ static void g364fb_init(DeviceState *dev, G364State *s) memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram", s->vram_size, s->vram); vmstate_register_ram(&s->mem_vram, dev); - memory_region_set_coalescing(&s->mem_vram); } #define TYPE_G364 "sysbus-g364" -- 2.4.1