From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1rrJ-0001XW-GV
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 03:52:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1rrG-0005f3-Qj
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 03:52:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47423)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1rrG-0005ep-LO
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 03:52:34 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 187728A4BC
	for <qemu-devel@nongnu.org>; Mon,  8 Jun 2015 07:52:34 +0000 (UTC)
Message-ID: <1433749951.5046.27.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 08 Jun 2015 09:52:31 +0200
In-Reply-To: <5571D986.2090802@redhat.com>
References: <1432899918-18513-1-git-send-email-kraxel@redhat.com>
	<1432899918-18513-3-git-send-email-kraxel@redhat.com>
	<5571D986.2090802@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add virtio gpu core code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>, qemu-devel@nongnu.org, "Michael S.
	Tsirkin" <mst@redhat.com>

  Hi,

> > +static uint32_t virtio_gpu_get_features(VirtIODevice *vdev, uint32_t features)
> > +{
> > +    return features;
> > +}
> 
> Does this series rely on some other patches? Because in master, 
> VirtioDeviceClass::get_features() is still uint64_t (*)(VirtioDevice *, 
> uint64_t) (which results in "hw/display/virtio-gpu.c:886:23: error: 
> assignment from incompatible pointer type" for me).

master was 32bit until recently (a few days back), now 64bit features
are finally merged and this mess should come to an end ;)

> (in an earlier series, this function was uint64_t ()(VirtIODevice *, 
> uint64_t))

Earlier versions used to depend on unmerged virtio patches, this one was
for master ...

> > +    if (ab->nr_entries > 1024) {
> > +        qemu_log_mask(LOG_GUEST_ERROR,
> > +                      "%s: nr_entries is too big (%d > 1024)\n",
> > +                      __func__, ab->nr_entries);
> > +        return -1;
> > +    }
> 
> Same question I had in said earlier series: Do you want to change this 
> to 16384, because 1024 may be too small?

Oops, fixed.

> > +#define VIRTIO_GPU_MAX_RES 16
> 
> Still unused. Still intentional? :-)

Fixed too.

cheers,
  Gerd