From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1w87-0001bx-5N
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:26:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1w7y-0004n0-FA
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:26:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1w7y-0004mX-8z
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:26:06 -0400
Message-ID: <1433766363.5046.37.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 08 Jun 2015 14:26:03 +0200
In-Reply-To: <CAFEAcA-SmWxuab2ny2SuN-hPnaEUqNfTdFo3PrK=w1=YnzQAOg@mail.gmail.com>
References: <1433513661-7267-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA-SmWxuab2ny2SuN-hPnaEUqNfTdFo3PrK=w1=YnzQAOg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/6] fw_cfg patch queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

> Hi. I'm afraid this fails make check for me:
> 
> GTESTER check-qtest-ppc
> qemu-system-ppc:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:426:
> fw_cfg_add_bytes_read_callback: Assertion `s->entries[arch][key].data
> == ((void *)0)' failed.
> Broken pipe
> GTester: last random seed: R02Sd9273ba718a6b28ff4381eed659a0cb4
> qemu-system-ppc:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:426:
> fw_cfg_add_bytes_read_callback: Assertion `s->entries[arch][key].data
> == ((void *)0)' failed.
> Broken pipe
> GTester: last random seed: R02S59d67a130b823e6e6d04a41eb4b168c7

Reproducer: "qemu-system-ppc -M g3beige -boot once=d,order=c".
Culprit: Patch #3 (fw_cfg: prevent selector key conflict).
Looks like FW_CFG_BOOT_DEVICE is set twice for macs.

Gabriel?  To me this looks like the assert found an actual bug ...

cheers,
  Gerd