From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1wFW-00074O-AF
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:33:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1wFR-0000tY-C9
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:33:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39708)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z1wFR-0000tS-6I
	for qemu-devel@nongnu.org; Mon, 08 Jun 2015 08:33:49 -0400
Message-ID: <1433766825.5046.42.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 08 Jun 2015 14:33:45 +0200
In-Reply-To: <20150608122355.GB32650@HEDWIG.INI.CMU.EDU>
References: <20150601153237.GE2120@HEDWIG.INI.CMU.EDU>
	<20150601174409-mutt-send-email-mst@redhat.com>
	<20150601180022.GI2120@HEDWIG.INI.CMU.EDU>
	<20150601203126.GK2120@HEDWIG.INI.CMU.EDU>
	<1433229074.1637.7.camel@nilsson.home.kraxel.org>
	<20150605160555.GH9951@HEDWIG.INI.CMU.EDU>
	<1433748105.5046.6.camel@redhat.com>
	<20150608114309-mutt-send-email-mst@redhat.com>
	<1433762362.5046.28.camel@redhat.com> <55758012.7060007@redhat.com>
	<20150608122355.GB32650@HEDWIG.INI.CMU.EDU>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] fw cfg files cross-version migration races
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: Paolo Bonzini <pbonzini@redhat.com>, lersek@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

 Hi,

> I'm wonderingjust when exactly to start sorting items in fw_cfg ? 

I'd suggest to sort as entries are added, i.e. just insert the new entry
at the correct place instead of tacking it to the end.  So the list is
always sorted.

> I'm also assuming this applies to named (file) entries only,

Yes, the other ones have a fixed index anyway.

cheers,
  Gerd