From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v2 9/9] iotests: Use event_wait in wait_ready
Date: Mon, 8 Jun 2015 14:06:25 +0100 [thread overview]
Message-ID: <1433768785-19413-10-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1433768785-19413-1-git-send-email-stefanha@redhat.com>
From: Fam Zheng <famz@redhat.com>
Only poll the specific type of event we are interested in, to avoid
stealing events that should be consumed by someone else.
Suggested-by: John Snow <jsnow@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 1433742974-20128-9-git-send-email-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qemu-iotests/iotests.py | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 63de726..8615b10 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -328,13 +328,8 @@ class QMPTestCase(unittest.TestCase):
def wait_ready(self, drive='drive0'):
'''Wait until a block job BLOCK_JOB_READY event'''
- ready = False
- while not ready:
- for event in self.vm.get_qmp_events(wait=True):
- if event['event'] == 'BLOCK_JOB_READY':
- self.assert_qmp(event, 'data/type', 'mirror')
- self.assert_qmp(event, 'data/device', drive)
- ready = True
+ f = {'data': {'type': 'mirror', 'device': drive } }
+ event = self.vm.event_wait(name='BLOCK_JOB_READY', match=f)
def wait_ready_and_cancel(self, drive='drive0'):
self.wait_ready(drive=drive)
--
2.4.2
next prev parent reply other threads:[~2015-06-08 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 13:06 [Qemu-devel] [PULL v2 0/9] Block patches Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 1/9] Revert "iothread: release iothread around aio_poll" Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 2/9] block: Add bdrv_get_block_status_above Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 3/9] qmp: Add optional bool "unmap" to drive-mirror Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 4/9] mirror: Do zero write on target if sectors not allocated Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 5/9] block: Fix dirty bitmap in bdrv_co_discard Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 6/9] block: Remove bdrv_reset_dirty Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 7/9] qemu-iotests: Make block job methods common Stefan Hajnoczi
2015-06-08 13:06 ` [Qemu-devel] [PULL v2 8/9] qemu-iotests: Add test case for mirror with unmap Stefan Hajnoczi
2015-06-08 13:06 ` Stefan Hajnoczi [this message]
2015-06-08 16:13 ` [Qemu-devel] [PULL v2 0/9] Block patches Eric Blake
2015-06-08 17:07 ` Peter Maydell
2015-06-09 14:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433768785-19413-10-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).